You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/02/17 20:47:21 UTC
[GitHub] [orc] omalley opened a new pull request #643: ORC-750: Fix bench to use orc pom as parent.
omalley opened a new pull request #643:
URL: https://github.com/apache/orc/pull/643
This refactors the benchmark pom so that it uses the orc pom as the parent.
That allows us to remove some duplication and means that the analyze profile becomes defined with benchmarks.
With that change, we now run findbugs and checkstyle on benchmark. Thus, we need to fix some findbugs
warnings and disable others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #643: ORC-750: Fix bench to use orc pom as parent.
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #643:
URL: https://github.com/apache/orc/pull/643#issuecomment-780871253
Changes LGTM - +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #643: ORC-750: Fix bench to use orc pom as parent.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #643:
URL: https://github.com/apache/orc/pull/643#issuecomment-804882392
Here is the PR to fix this.
- https://github.com/apache/orc/pull/667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #643: ORC-750: Fix bench to use orc pom as parent.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #643:
URL: https://github.com/apache/orc/pull/643#issuecomment-780896217
BTW, do you know why Travis CI is failing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] omalley commented on pull request #643: ORC-750: Fix bench to use orc pom as parent.
Posted by GitBox <gi...@apache.org>.
omalley commented on pull request #643:
URL: https://github.com/apache/orc/pull/643#issuecomment-780929750
It looks like it is passing now. https://www.travis-ci.com/github/apache/orc/builds/217427153
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #643: ORC-750: Fix bench to use orc pom as parent.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #643:
URL: https://github.com/apache/orc/pull/643#discussion_r599525591
##########
File path: java/bench/pom.xml
##########
@@ -17,10 +17,10 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
- <groupId>org.apache</groupId>
- <artifactId>apache</artifactId>
- <version>18</version>
- <relativePath></relativePath>
+ <groupId>org.apache.orc</groupId>
+ <artifactId>orc</artifactId>
+ <version>1.7.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
Review comment:
This seems to break uber jar building in `spark` submodule.
```
$ cd java/bench
$ mvn clean package -pl spark --am
$ ls -alh spark/target/*.jar
-rw-rw-r-- 1 dongjoon dongjoon 62K Mar 23 05:28 spark/target/orc-benchmarks-spark-1.7.0-SNAPSHOT.jar
-rw-rw-r-- 1 dongjoon dongjoon 808K Mar 23 05:28 spark/target/orc-benchmarks-spark-1.7.0-SNAPSHOT-nohive.jar
```
The correct uber jar should be 129MB.
```
$ ls -alh spark/target/*.jar
-rw-rw-r-- 1 dongjoon dongjoon 129M Mar 23 05:32 spark/target/orc-benchmarks-spark-1.7.0-SNAPSHOT.jar
-rw-rw-r-- 1 dongjoon dongjoon 63K Mar 23 05:32 spark/target/original-orc-benchmarks-spark-1.7.0-SNAPSHOT.jar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] omalley merged pull request #643: ORC-750: Fix bench to use orc pom as parent.
Posted by GitBox <gi...@apache.org>.
omalley merged pull request #643:
URL: https://github.com/apache/orc/pull/643
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #643: ORC-750: Fix bench to use orc pom as parent.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #643:
URL: https://github.com/apache/orc/pull/643#discussion_r599526405
##########
File path: java/bench/pom.xml
##########
@@ -17,10 +17,10 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
- <groupId>org.apache</groupId>
- <artifactId>apache</artifactId>
- <version>18</version>
- <relativePath></relativePath>
+ <groupId>org.apache.orc</groupId>
+ <artifactId>orc</artifactId>
+ <version>1.7.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
Review comment:
I'll make a PR to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org