[GitHub] [spark] maropu commented on a change in pull request #27759: [SPARK-31008][SQL]Support json_array_length function

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #27759: [SPARK-31008][SQL]Support json_array_length function
URL: https://github.com/apache/spark/pull/27759#discussion_r388004965
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
 ##########
 @@ -781,3 +782,67 @@ case class SchemaOfJson(
 
   override def prettyName: String = "schema_of_json"
 }
+
+/**
+ * A function that returns number of elements in outer Json Array.
+ */
+@ExpressionDescription(
+  usage = "_FUNC_(jsonArray) - Returns length of the jsonArray",
+  arguments = """
+    jsonArray - A JSON array is required as argument. `Analysis Exception` is thrown if any other
+    valid JSON expression is passed. `NULL` is returned in case of invalid JSON.
 
 Review comment:
   Can you follow the other format? e.g., https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala#L292

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org