Re: [PR] fix(toasts): stop the toast overlay from covering controls behind it [superset]

["jesperct (via GitHub)" <gi...@apache.org>]

jesperct commented on code in PR #40805:
URL: https://github.com/apache/superset/pull/40805#discussion_r3364495548


##########
superset-frontend/src/components/MessageToasts/ToastPresenter.tsx:
##########
@@ -39,6 +39,9 @@ const StyledToastPresenter = styled.div<VisualProps>(
 
     height: calc(100vh - 100px);
 
+    /* Full-height overlay: pass clicks through empty area; toasts re-enable below. */
+    pointer-events: none;

Review Comment:
   Confirmed, and reworked the fix to avoid this. Instead of pointer-events:none on the scroll container (which would have disabled scrollbar dragging), I changed the container's `height: calc(100vh - 100px)` to `max-height`, so it hugs its toasts and the fixed overlay no longer covers the buttons. overflow-y:auto still scrolls the stack when toasts overflow, and the scrollbar stays interactive. Fixed in f975f91.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org