You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/07/25 14:16:03 UTC

[GitHub] [accumulo] EdColeman commented on pull request #2824: Spotbugs plugin update to current version 4.7.1

EdColeman commented on PR #2824:
URL: https://github.com/apache/accumulo/pull/2824#issuecomment-1194107775

   Making `lastMemoryCheckTime` private changes the current behavior.  Not sure if that is necessary - but seemed the best course of action was to preserve the current behavior and then consider refactoring.  If there are multiple instances created in a server, the current behavior is that the log / check will run once per defined period even if there were multiple instance created.
   
   It may be desirable to lift the GCLogger to AbstractSever so that it is initialized / runs once per server process without static and possible synchronization required - but that seemed outside of the scope of this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org