You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/01/06 05:09:20 UTC
[GitHub] [kafka] wenbingshen opened a new pull request #9831: MINOR: rename iff to if
wenbingshen opened a new pull request #9831:
URL: https://github.com/apache/kafka/pull/9831
As the title
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wenbingshen commented on a change in pull request #9831: MINOR: rename iff to if
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on a change in pull request #9831:
URL: https://github.com/apache/kafka/pull/9831#discussion_r552408736
##########
File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
##########
@@ -66,7 +66,7 @@ public ClusterConnectionStates(long reconnectBackoffMs, long reconnectBackoffMax
}
/**
- * Return true iff we can currently initiate a new connection. This will be the case if we are not
+ * Return true if we can currently initiate a new connection. This will be the case if we are not
Review comment:
I need to improve my English, thanks for your explanation, I will close this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wenbingshen closed pull request #9831: MINOR: rename iff to if
Posted by GitBox <gi...@apache.org>.
wenbingshen closed pull request #9831:
URL: https://github.com/apache/kafka/pull/9831
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9831: MINOR: rename iff to if
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9831:
URL: https://github.com/apache/kafka/pull/9831#discussion_r552406887
##########
File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
##########
@@ -66,7 +66,7 @@ public ClusterConnectionStates(long reconnectBackoffMs, long reconnectBackoffMax
}
/**
- * Return true iff we can currently initiate a new connection. This will be the case if we are not
+ * Return true if we can currently initiate a new connection. This will be the case if we are not
Review comment:
It means "if and only if".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org