You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/11 09:39:37 UTC

[GitHub] [flink-table-store] liyubin117 opened a new pull request, #89: [FLINK-27172] Support bulk based format provided by Flink

liyubin117 opened a new pull request, #89:
URL: https://github.com/apache/flink-table-store/pull/89

   the following format should be supported in flink-table-store:
   1. built in flink-table-store, such as avro/orc, supported already
   2. provided by Flink, such as parquet/csv, has not been supported yet


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-table-store] JingsongLi merged pull request #89: [FLINK-27172] Support bulk based format provided by Flink

Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #89:
URL: https://github.com/apache/flink-table-store/pull/89


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-table-store] liyubin117 commented on a diff in pull request #89: [FLINK-27172] Support bulk based format provided by Flink

Posted by GitBox <gi...@apache.org>.
liyubin117 commented on code in PR #89:
URL: https://github.com/apache/flink-table-store/pull/89#discussion_r847343312


##########
flink-table-store-dist/pom.xml:
##########
@@ -118,8 +112,6 @@ under the License.
                                     <include>org.apache.flink:flink-table-store-core</include>
                                     <include>org.apache.flink:flink-table-store-format</include>
                                     <include>org.apache.flink:flink-table-store-kafka</include>
-                                    <include>org.apache.flink:flink-connector-base</include>

Review Comment:
   exception as follow:
   ```
   Could not find any factories that implement 'org.apache.flink.table.store.shaded.org.apache.flink.connector.file.table.factories.BulkReaderFormatFactory' in the classpath.
       at org.apache.flink.table.factories.FactoryUtil.discoverFactory(FactoryUtil.java:526) 
   ```
   the detailed reason is that flink-table-store use `FileFormatImpl` to discover formats implementing `BulkReaderFormatFactory` provided by Flink, but the name of interface has been shaded into different one, caused the exception as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #89: [FLINK-27172] Support bulk based format provided by Flink

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #89:
URL: https://github.com/apache/flink-table-store/pull/89#discussion_r847259164


##########
flink-table-store-dist/pom.xml:
##########
@@ -118,8 +112,6 @@ under the License.
                                     <include>org.apache.flink:flink-table-store-core</include>
                                     <include>org.apache.flink:flink-table-store-format</include>
                                     <include>org.apache.flink:flink-table-store-kafka</include>
-                                    <include>org.apache.flink:flink-connector-base</include>

Review Comment:
   This is the reason? Can you post the exceptions?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-table-store] liyubin117 commented on a diff in pull request #89: [FLINK-27172] Support bulk based format provided by Flink

Posted by GitBox <gi...@apache.org>.
liyubin117 commented on code in PR #89:
URL: https://github.com/apache/flink-table-store/pull/89#discussion_r847343312


##########
flink-table-store-dist/pom.xml:
##########
@@ -118,8 +112,6 @@ under the License.
                                     <include>org.apache.flink:flink-table-store-core</include>
                                     <include>org.apache.flink:flink-table-store-format</include>
                                     <include>org.apache.flink:flink-table-store-kafka</include>
-                                    <include>org.apache.flink:flink-connector-base</include>

Review Comment:
   Hi, @JingsongLi , Thanks for your reply.
   exception as follow:
   ```
   Could not find any factories that implement 'org.apache.flink.table.store.shaded.org.apache.flink.connector.file.table.factories.BulkReaderFormatFactory' in the classpath.
       at org.apache.flink.table.factories.FactoryUtil.discoverFactory(FactoryUtil.java:526) 
   ```
   the detailed reason is that flink-table-store use `FileFormatImpl` to discover formats implementing `BulkReaderFormatFactory` provided by Flink, but the name of interface has been shaded into different one, caused the exception as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org