You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/09/10 11:49:59 UTC
[GitHub] [trafficserver] brbzull0 opened a new pull request #8319: Fix yamlcpp include folder by using the YAMLCPP_INCLUDE variable,
brbzull0 opened a new pull request #8319:
URL: https://github.com/apache/trafficserver/pull/8319
Fix yamlcpp include folder by using the YAMLCPP_INCLUDE variable,
so if we configure our own version of yamlcpp then the right include files will be picked up.
This will avoid mixin up the internal and the configured yamlcpp library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8319: Fix yamlcpp include folder by using the YAMLCPP_INCLUDE variable
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8319:
URL: https://github.com/apache/trafficserver/pull/8319#issuecomment-917080368
This changed fixes issue #8253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8319: Fix yamlcpp include folder by using the YAMLCPP_INCLUDE variable
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #8319:
URL: https://github.com/apache/trafficserver/pull/8319#issuecomment-924395469
One half the patch is from #7948, but the other half is from 9db871a399 , so it will conflict. But I think this should go in since it blocks people from using newer out of tree yaml-cpp in 9.1.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall edited a comment on pull request #8319: Fix yamlcpp include folder by using the YAMLCPP_INCLUDE variable
Posted by GitBox <gi...@apache.org>.
bryancall edited a comment on pull request #8319:
URL: https://github.com/apache/trafficserver/pull/8319#issuecomment-917080368
I tested the change and it fixes issue #8253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 merged pull request #8319: Fix yamlcpp include folder by using the YAMLCPP_INCLUDE variable
Posted by GitBox <gi...@apache.org>.
brbzull0 merged pull request #8319:
URL: https://github.com/apache/trafficserver/pull/8319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8319: Fix yamlcpp include folder by using the YAMLCPP_INCLUDE variable
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8319:
URL: https://github.com/apache/trafficserver/pull/8319#issuecomment-920370872
Do we really need this in 9.1.x ? I think this fixes something that was introduced in #7948, which is not in 9.1.x (but will be in 9.2.x)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #8319: Fix yamlcpp include folder by using the YAMLCPP_INCLUDE variable
Posted by GitBox <gi...@apache.org>.
brbzull0 commented on pull request #8319:
URL: https://github.com/apache/trafficserver/pull/8319#issuecomment-916845348
@bryancall I think you are looking at this https://github.com/apache/trafficserver/issues/8253 . I had this same issues locally in my Linux box and this fixed it. Haven't try on mac but I am pretty confident that this will fix the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org