[DISCUSS] move nifi-assembly into top level

[Joe Witt <jo...@gmail.com>]

Hello,

With the work going on with NIFI-850 [1] and NIFI-857 [2] things will
be much cleaner and simpler.  One thing that came up from a NiFi user
was how weird they thought it was that we had a 'nifi-assembly'
subproject that they had to go to so they could find the build.  Back
when NiFi wasn't open sourced this approach made sense but at this
point I couldn't actually make an argument for why we should still do
that.

I've created a JIRA to just move the assembly mechanism up to the root
of the project NIFI-858 [3] but before I tackle that it seems like a
good one to send out to the group and see if folks have thoughts on
this.  Can anyone see a reason why this is a bad idea?

Thanks
Joe

[1] https://issues.apache.org/jira/browse/NIFI-850
[2] https://issues.apache.org/jira/browse/NIFI-857
[3] https://issues.apache.org/jira/browse/NIFI-858

Re: [DISCUSS] move nifi-assembly into top level

[Joe Witt <jo...@gmail.com>]

Sean,

All of those points really make sense to me.  I'll take a look at the
copying idea.  That would be more than sufficient I suspect.

Thanks
Joe

On Sun, Aug 16, 2015 at 2:45 PM, Sean Busbey <bu...@cloudera.com> wrote:
> It's been easier, in my experience, to properly work out maven tooling to
> build assemblies with all of the needed legal bits via a dedicated assembly
> submodule rather than having it at the top level.
>
> Consider build order. The assembly should have a dependency on all the
> modules it includes so that maven knows to build it last. If the assembly
> is at the top pom and that pom is the parent for the submodules it
> contains, how does that work out?
>
> What if we just had a flag (default true) that controlled copying the
> finished assembly to a top level target directory?
>
> --
> Sean
> On Aug 15, 2015 11:32 AM, "Joe Witt" <jo...@gmail.com> wrote:
>
>> Hello,
>>
>> With the work going on with NIFI-850 [1] and NIFI-857 [2] things will
>> be much cleaner and simpler.  One thing that came up from a NiFi user
>> was how weird they thought it was that we had a 'nifi-assembly'
>> subproject that they had to go to so they could find the build.  Back
>> when NiFi wasn't open sourced this approach made sense but at this
>> point I couldn't actually make an argument for why we should still do
>> that.
>>
>> I've created a JIRA to just move the assembly mechanism up to the root
>> of the project NIFI-858 [3] but before I tackle that it seems like a
>> good one to send out to the group and see if folks have thoughts on
>> this.  Can anyone see a reason why this is a bad idea?
>>
>> Thanks
>> Joe
>>
>> [1] https://issues.apache.org/jira/browse/NIFI-850
>> [2] https://issues.apache.org/jira/browse/NIFI-857
>> [3] https://issues.apache.org/jira/browse/NIFI-858
>>

Re: [DISCUSS] move nifi-assembly into top level

[Sean Busbey <bu...@cloudera.com>]

It's been easier, in my experience, to properly work out maven tooling to
build assemblies with all of the needed legal bits via a dedicated assembly
submodule rather than having it at the top level.

Consider build order. The assembly should have a dependency on all the
modules it includes so that maven knows to build it last. If the assembly
is at the top pom and that pom is the parent for the submodules it
contains, how does that work out?

What if we just had a flag (default true) that controlled copying the
finished assembly to a top level target directory?

-- 
Sean
On Aug 15, 2015 11:32 AM, "Joe Witt" <jo...@gmail.com> wrote:

> Hello,
>
> With the work going on with NIFI-850 [1] and NIFI-857 [2] things will
> be much cleaner and simpler.  One thing that came up from a NiFi user
> was how weird they thought it was that we had a 'nifi-assembly'
> subproject that they had to go to so they could find the build.  Back
> when NiFi wasn't open sourced this approach made sense but at this
> point I couldn't actually make an argument for why we should still do
> that.
>
> I've created a JIRA to just move the assembly mechanism up to the root
> of the project NIFI-858 [3] but before I tackle that it seems like a
> good one to send out to the group and see if folks have thoughts on
> this.  Can anyone see a reason why this is a bad idea?
>
> Thanks
> Joe
>
> [1] https://issues.apache.org/jira/browse/NIFI-850
> [2] https://issues.apache.org/jira/browse/NIFI-857
> [3] https://issues.apache.org/jira/browse/NIFI-858
>