[jira] [Commented] (CB-12250) config-file plist entries not removed on plugin rm

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-12250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946857#comment-15946857 ] 

ASF GitHub Bot commented on CB-12250:
-------------------------------------

GitHub user matrosov-nikita opened a pull request:

    https://github.com/apache/cordova-lib/pull/533

    CB-12250 CB-12409 iOS: Fix bug with escaping properties from plist file

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    This PR fixes some bugs with removing properties from `.plist` file
    
    ### What testing has been done on this change?
    auto-test
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosov-nikita/cordova-lib CB-12409

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/533.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #533
    
----
commit 2f5a4dfc09865a10c5cfc8318f4b44cc2273267c
Author: Nikita Matrosov <v-...@microsoft.com>
Date:   2017-03-01T15:31:39Z

    CB-12250 CB-12409 iOS: Fix bug with escaping properties from plist file

----


> config-file plist <array> entries not removed on plugin rm
> ----------------------------------------------------------
>
>                 Key: CB-12250
>                 URL: https://issues.apache.org/jira/browse/CB-12250
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Sergey Shakhnazarov
>            Assignee: Nikita Matrosov
>              Labels: ios, triaged
>
> 1. {{cordova plugin add cordova-plugin-ms-adal@0.8.1}}
> 2. {{cat platforms/ios/HelloCordova/HelloCordova-Info.plist}}
> ->
> {noformat}
> ...
>     <key>CFBundleURLTypes</key>
>     <array>
>       <dict>
>         <key>CFBundleTypeRole</key>
>         <string>Editor</string>
>         <key>CFBundleURLName</key>
>         <string>$(CFBundleIdentifier)</string>
>         <key>CFBundleURLSchemes</key>
>         <array>
>           <string>x-msauth-$(CFBundleIdentifier:rfc1034identifier)</string>
>         </array>
>       </dict>
> {noformat}
> 3. {{cordova plugin rm ms-adal}}
> {{cat platforms/ios/HelloCordova/HelloCordova-Info.plist}}
> -> CFBundleURLTypes not removed
> 4. The array will be populated with another duplicating entry on next plugin install.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org