You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by BabakAp <gi...@git.apache.org> on 2016/02/22 02:19:02 UTC

[GitHub] incubator-madlib pull request: Fixed errors in hello_world example

GitHub user BabakAp opened a pull request:

    https://github.com/apache/incubator-madlib/pull/20

    Fixed errors in hello_world example

    Fixes MADLIB-967 Hello World Example Errors

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BabakAp/incubator-madlib master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-madlib/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20
    
----
commit 87fb0ce2f4c00a77f9d5632c2cecc774c3a2de3e
Author: Babak Alipour <ba...@gmail.com>
Date:   2016-02-22T01:17:03Z

    Fixed errors in hello_world example

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib pull request: Fixed errors in hello_world example

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-madlib/pull/20


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib pull request: Fixed errors in hello_world example

Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on the pull request:

    https://github.com/apache/incubator-madlib/pull/20#issuecomment-187464027
  
    LGTM except the 4 commits need to be squashed and the commit message needs to be updated per the guidelines (Step 5 of [contribution guide](https://cwiki.apache.org/confluence/display/MADLIB/Contribution+Guidelines)).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---