You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/16 14:49:07 UTC

[GitHub] [apisix] HelloBug0 opened a new pull request #2766: feat: add a switch of access log

HelloBug0 opened a new pull request #2766:
URL: https://github.com/apache/apisix/pull/2766


   ### What this PR does / why we need it:
   satify the need of [#2713](https://github.com/apache/apisix/issues/2713)
   
   ### Pre-submission checklist:
   
   * [X] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [X] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] HelloBug0 closed pull request #2766: feat: add a switch of access log

Posted by GitBox <gi...@apache.org>.
HelloBug0 closed pull request #2766:
URL: https://github.com/apache/apisix/pull/2766


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] HelloBug0 commented on pull request #2766: feat: add a switch of access log

Posted by GitBox <gi...@apache.org>.
HelloBug0 commented on pull request #2766:
URL: https://github.com/apache/apisix/pull/2766#issuecomment-728587183


   > #2765 should be put into this one.
   
   It occurs to me, but it's kind of awkward that I still don't know how to PR once with two changed files in windows even after I searched that in the Internet. I realize that I need to learn more about git operations.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #2766: feat: add a switch of access log

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #2766:
URL: https://github.com/apache/apisix/pull/2766#discussion_r524345630



##########
File path: conf/config-default.yaml
##########
@@ -128,6 +128,7 @@ nginx_config:                     # config for render the template to genarate n
   #envs:                            # allow to get a list of environment variables
   #  - TEST_ENV
   http:
+    access_log_switch: on          # on or off, default on

Review comment:
       Better to use `enable_access_log: true` to ensure consistency.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] HelloBug0 commented on a change in pull request #2766: feat: add a switch of access log

Posted by GitBox <gi...@apache.org>.
HelloBug0 commented on a change in pull request #2766:
URL: https://github.com/apache/apisix/pull/2766#discussion_r524806755



##########
File path: conf/config-default.yaml
##########
@@ -128,6 +128,7 @@ nginx_config:                     # config for render the template to genarate n
   #envs:                            # allow to get a list of environment variables
   #  - TEST_ENV
   http:
+    access_log_switch: on          # on or off, default on

Review comment:
       yeah, right




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on pull request #2766: feat: add a switch of access log

Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #2766:
URL: https://github.com/apache/apisix/pull/2766#issuecomment-728130999


   #2765 should be put into this one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org