You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Sascha Rodekamp (JIRA)" <ji...@apache.org> on 2010/02/22 10:24:27 UTC
[jira] Created: (OFBIZ-3491) Refactor fieldlookup.js
Refactor fieldlookup.js
-----------------------
Key: OFBIZ-3491
URL: https://issues.apache.org/jira/browse/OFBIZ-3491
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: SVN trunk
Reporter: Sascha Rodekamp
Fix For: SVN trunk
Attachments: OFBIZ-3491_lookup_refactor.patch
A few changes in the fieldlookup.js to make the code a little bit smaller.
BTW. the fieldLookupLayer3 works now. You can pass to different values in two different form fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3491) Refactor fieldlookup.js
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-3491:
--------------------------------------
Assignee: Jacques Le Roux
> Refactor fieldlookup.js
> -----------------------
>
> Key: OFBIZ-3491
> URL: https://issues.apache.org/jira/browse/OFBIZ-3491
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3491_lookup_refactor.patch
>
>
> A few changes in the fieldlookup.js to make the code a little bit smaller.
> BTW. the fieldLookupLayer3 works now. You can pass to different values in two different form fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3491) Refactor fieldlookup.js
Posted by "Sascha Rodekamp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sascha Rodekamp updated OFBIZ-3491:
-----------------------------------
Attachment: OFBIZ-3491_lookup_refactor.patch
> Refactor fieldlookup.js
> -----------------------
>
> Key: OFBIZ-3491
> URL: https://issues.apache.org/jira/browse/OFBIZ-3491
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3491_lookup_refactor.patch
>
>
> A few changes in the fieldlookup.js to make the code a little bit smaller.
> BTW. the fieldLookupLayer3 works now. You can pass to different values in two different form fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3491) Refactor fieldlookup.js
Posted by "Sascha Rodekamp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sascha Rodekamp closed OFBIZ-3491.
----------------------------------
Resolution: Fixed
Patch moved to [OFBIZ-3524|https://issues.apache.org/jira/browse/OFBIZ-3524]
> Refactor fieldlookup.js
> -----------------------
>
> Key: OFBIZ-3491
> URL: https://issues.apache.org/jira/browse/OFBIZ-3491
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3491_lookup_refactor.patch
>
>
> A few changes in the fieldlookup.js to make the code a little bit smaller.
> BTW. the fieldLookupLayer3 works now. You can pass to different values in two different form fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3491) Refactor fieldlookup.js
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839474#action_12839474 ]
Jacques Le Roux commented on OFBIZ-3491:
----------------------------------------
Thanks Sascha,
Your patch is in trunk at r917250 .
I prefer to handle specific and smaller patch like this one than merging them in one bigger and harder to review. BTW it's also the best practices to isolate things like you did here.
> Refactor fieldlookup.js
> -----------------------
>
> Key: OFBIZ-3491
> URL: https://issues.apache.org/jira/browse/OFBIZ-3491
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3491_lookup_refactor.patch
>
>
> A few changes in the fieldlookup.js to make the code a little bit smaller.
> BTW. the fieldLookupLayer3 works now. You can pass to different values in two different form fields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.