[GitHub] ctubbsii commented on issue #897: Fixes #810 - Replace MiniAccumulo LogWriter's with ProcessBuilder.red…

[GitBox <gi...@apache.org>]

ctubbsii commented on issue #897: Fixes #810 - Replace MiniAccumulo LogWriter's with ProcessBuilder.red…
URL: https://github.com/apache/accumulo/pull/897#issuecomment-454593730
 
 
   Hi @jzgithub1 . Thanks for the patch. I don't have time right this moment to review this (it seems others are on it anyway), but I did want to jump in quickly to comment on your git log messages, because I noticed that this pull request and the one in #901 both had long enough subject lines in the git commit log that GitHub wrapped them into the body.
   
   Chris Beams had a good blog post about creating git log messages at https://chris.beams.io/posts/git-commit/ that I often refer people to.
   
   For example, the log message on this issue could be improved similarly to:
   
   ```
   Fix #810 Use builtins to redirect console in mini
   
   Use Java ProcessBuilder.redirectOutput() instead of custom code to redirect
   console output for processes launched by MiniAccumuloCluster.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services