[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #10701: [refactor](predicate) refactor predicates in scan node

[GitBox <gi...@apache.org>]

BiteTheDDDDt commented on code in PR #10701:
URL: https://github.com/apache/doris/pull/10701#discussion_r916809110


##########
be/src/vec/exec/volap_scan_node.cpp:
##########
@@ -937,7 +944,7 @@ std::pair<bool, void*> VOlapScanNode::should_push_down_eq_predicate(doris::SlotD
     return result_pair;
 }
 
-template <typename T, typename ChangeFixedValueRangeFunc>
+template <PrimitiveType T, typename ChangeFixedValueRangeFunc>
 Status VOlapScanNode::change_fixed_value_range(ColumnValueRange<T>& temp_range, PrimitiveType type,
                                                void* value, const ChangeFixedValueRangeFunc& func) {

Review Comment:
   Does `T` always equal to `type`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org