[GitHub] [skywalking-nginx-lua] 861763765 commented on a change in pull request #29: Add customer parameter for java agent config "agent.namespace"

[GitBox <gi...@apache.org>]

861763765 commented on a change in pull request #29: Add customer parameter for java agent config "agent.namespace"
URL: https://github.com/apache/skywalking-nginx-lua/pull/29#discussion_r403432140
 
 

 ##########
 File path: README.md
 ##########
 @@ -47,8 +47,9 @@ http {
                 -- Please set them as service logic name or DNS name
                 --
                 -- Currently, we can not have the upstream real network address
+                -- The parameter "customer_namespace" for java agent config "agent.namespace"
                 ------------------------------------------------------
-                require("tracer"):start("upstream service")
+                require("tracer"):start("upstream service", "customer_namespace")
 
 Review comment:
   Yes, this parameter will be used only after we use the configuration of “agent.namespace” in the java agent. if we don't use it , this parameter can be nil

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services