[jira] Commented: (MDEP-43) includeClassifiers configuration parameter

["Stephane Nicoll (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MDEP-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_85783 ] 

Stephane Nicoll commented on MDEP-43:
-------------------------------------

Does not seem to work ....

I have a project with 3 deps on modules and its sources (6 dependencies in total). I configure the plugin to only include the "sources" classifier and it expands the 6 dependencies

{noformat}
[INFO] [dependency:unpack-dependencies {execution: unpack-dependencies}]
[DEBUG] Excluding Transitive Dependencies.
[DEBUG] Added: com.foo.shared:foo-b:jar:sources:5.5.0-SNAPSHOT:compile
[DEBUG] Added: com.foo.shared:foo-a:jar:sources:5.5.0-SNAPSHOT:compile
[DEBUG] Added: com.foo.shared:foo-c:jar:sources:5.5.0-SNAPSHOT:compile
[DEBUG] Added: com.foo.shared:foo-c:jar:5.5.0-SNAPSHOT:compile
[DEBUG] Added: com.foo.shared:foo-a:jar:5.5.0-SNAPSHOT:compile
[DEBUG] Added: com.foo.shared:foo-b:jar:5.5.0-SNAPSHOT:compile
[DEBUG] Added 6
[DEBUG] Including only Classifiers: sources
{noformat}

The config is as follow:

{noformat}
         <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-dependency-plugin</artifactId>
                <executions>
                    <execution>
                        <id>unpack-dependencies</id>
                        <phase>generate-resources</phase>
                        <goals>
                            <goal>unpack-dependencies</goal>
                        </goals>
                        <configuration>
                            <includeClassifiers>sources</includeClassifiers>
                            <excludeTransitive>true</excludeTransitive>
                            <outputDirectory>${project.build.directory}/javadoc-src</outputDirectory>
                        </configuration>
                    </execution>
                </executions>
            </plugin>
{noformat}

> includeClassifiers configuration parameter
> ------------------------------------------
>
>                 Key: MDEP-43
>                 URL: http://jira.codehaus.org/browse/MDEP-43
>             Project: Maven 2.x Dependency Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.0-alpha-1
>            Reporter: Richard van der Hoff
>            Priority: Minor
>             Fix For: 2.0-alpha-1
>
>         Attachments: patch
>
>
> Would it be possible to add an "includeClassifiers" parameter to AbstractDependencyFilterMojo?
> The attached patch implements this; I've factored the code which would be common to the TypeFilter and ClassifierFilter into a common base class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira