You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/08 13:58:02 UTC

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10678: TRIVIAL: Fix type inconsistencies, unthrown exceptions, etc

dongjinleekr commented on a change in pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#discussion_r647468635



##########
File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##########
@@ -314,7 +314,6 @@ class GroupMetadataManager(brokerId: Int,
 
       case None =>
         responseCallback(Errors.NOT_COORDINATOR)
-        None

Review comment:
       Exactly. This is how ide (IntelliJ 2021.1.2 + scala 2021.1.21) is showing - a dead code with a gray marking.
   
   ![Screenshot from 2021-06-08 22-56-14](https://user-images.githubusercontent.com/2375128/121197999-be71ef00-c8ac-11eb-981b-25bbc8e87404.png)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org