You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2017/10/06 19:09:35 UTC

[GitHub] spark pull request #18460: [SPARK-21247][SQL] Type comparison should respect...

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18460#discussion_r143273000
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ---
    @@ -100,6 +101,17 @@ object TypeCoercion {
         case (_: TimestampType, _: DateType) | (_: DateType, _: TimestampType) =>
           Some(TimestampType)
     
    +    case (t1 @ StructType(fields1), t2 @ StructType(fields2)) if t1.sameType(t2) =>
    +      Some(StructType(fields1.zip(fields2).map { case (f1, f2) =>
    +        // Since `t1.sameType(t2)` is true, two StructTypes have the same DataType
    +        // except `name` (in case of `spark.sql.caseSensitive=false`) and `nullable`.
    +        // - Different names: use a lower case name because findTightestCommonType is commutative.
    +        // - Different nullabilities: `nullable` is true iff one of them is nullable.
    +        val name = if (f1.name == f2.name) f1.name else f1.name.toLowerCase(Locale.ROOT)
    --- End diff --
    
    Yes. Hive does like the following.
    ```sql
    hive> CREATE TABLE S AS SELECT named_struct('A',1);
    hive> DESCRIBE S;
    OK
    _c0                 	struct<a:int>
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org