[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6153: add more validation for upsert config

[GitBox <gi...@apache.org>]

yupeng9 commented on a change in pull request #6153:
URL: https://github.com/apache/incubator-pinot/pull/6153#discussion_r508001095



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/util/SchemaUtils.java
##########
@@ -92,6 +93,9 @@ public static void validate(Schema schema) {
                 "Exception in getting arguments for transform function '" + transformFunction + "' for column '"
                     + column + "'", e);
           }
+        } else if (fieldSpec.getFieldType().equals(FieldSpec.FieldType.TIME) && fieldSpec.getFieldType()

Review comment:
       typo. missed negation




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org