You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/11/27 06:39:31 UTC
Re: [PR] [SPARK-46118][SQL][SS][CONNECT] Use `SparkSession.sessionState.conf` instead of `SQLContext.conf` and mark `SQLContext.conf` as deprecated [spark]
LuciferYang commented on code in PR #44034:
URL: https://github.com/apache/spark/pull/44034#discussion_r1405679136
##########
sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala:
##########
@@ -78,6 +78,7 @@ class SQLContext private[sql](val sparkSession: SparkSession)
private[sql] def sessionState: SessionState = sparkSession.sessionState
private[sql] def sharedState: SharedState = sparkSession.sharedState
+ @deprecated("Use SparkSession.sessionState.conf instead", "4.0.0")
private[sql] def conf: SQLConf = sessionState.conf
Review Comment:
This is not a public API, can it be deleted directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org