You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2019/01/02 18:54:40 UTC
[GitHub] jvrao commented on a change in pull request #1883: Enhance
EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.
jvrao commented on a change in pull request #1883: Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.
URL: https://github.com/apache/bookkeeper/pull/1883#discussion_r244820288
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookKeeperServerStats.java
##########
@@ -69,6 +69,11 @@
String WATCHER_SCOPE = "bookie_watcher";
String REPLACE_BOOKIE_TIME = "REPLACE_BOOKIE_TIME";
String NEW_ENSEMBLE_TIME = "NEW_ENSEMBLE_TIME";
+ String FAILED_TO_RESOLVE_NETWORK_LOCATION_COUNTER = "FAILED_TO_RESOLVE_NETWORK_LOCATION_COUNTER";
+ String NEW_ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_COUNTER =
+ "NEW_ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_COUNTER";
+ String REPLACE_BOOKIE_NOT_ADHERING_TO_PLACEMENT_POLICY_COUNTER =
+ "REPLACE_BOOKIE_NOT_ADHERING_TO_PLACEMENT_POLICY_COUNTER";
Review comment:
What is the benefit of tracking these things separately? Do you plan to act differently? If not, I would make it one instead of cluttering further.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services