You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2009/07/15 12:42:11 UTC
svn commit: r794222 - in /qpid/trunk/qpid/java/management/eclipse-plugin:
icons/ src/main/java/org/apache/qpid/management/ui/
src/main/java/org/apache/qpid/management/ui/views/
src/main/java/org/apache/qpid/management/ui/views/connection/
src/main/java...
Author: robbie
Date: Wed Jul 15 10:42:10 2009
New Revision: 794222
URL: http://svn.apache.org/viewvc?rev=794222&view=rev
Log:
QPID-1966: add status bar for operation feedback reports
Added:
qpid/trunk/qpid/java/management/eclipse-plugin/icons/failure.gif
qpid/trunk/qpid/java/management/eclipse-plugin/icons/success.gif
Modified:
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/ApplicationRegistry.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/ApplicationWorkbenchWindowAdvisor.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/Constants.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/MBeanView.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/ViewUtility.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/connection/ConnectionOperationsTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/ExchangeOperationsTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/HeadersExchangeOperationsTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/ConfigurationFileTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/RuntimeTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/queue/QueueOperationsTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/users/UserManagementTabControl.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/vhost/VHostTabControl.java
Added: qpid/trunk/qpid/java/management/eclipse-plugin/icons/failure.gif
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/icons/failure.gif?rev=794222&view=auto
==============================================================================
Files qpid/trunk/qpid/java/management/eclipse-plugin/icons/failure.gif (added) and qpid/trunk/qpid/java/management/eclipse-plugin/icons/failure.gif Wed Jul 15 10:42:10 2009 differ
Added: qpid/trunk/qpid/java/management/eclipse-plugin/icons/success.gif
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/icons/success.gif?rev=794222&view=auto
==============================================================================
Files qpid/trunk/qpid/java/management/eclipse-plugin/icons/success.gif (added) and qpid/trunk/qpid/java/management/eclipse-plugin/icons/success.gif Wed Jul 15 10:42:10 2009 differ
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/ApplicationRegistry.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/ApplicationRegistry.java?rev=794222&r1=794221&r2=794222&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/ApplicationRegistry.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/ApplicationRegistry.java Wed Jul 15 10:42:10 2009
@@ -46,6 +46,10 @@
static
{
+ imageRegistry.put(Constants.SUCCESS_IMAGE,
+ org.apache.qpid.management.ui.Activator.getImageDescriptor("/icons/success.gif"));
+ imageRegistry.put(Constants.FAILURE_IMAGE,
+ org.apache.qpid.management.ui.Activator.getImageDescriptor("/icons/failure.gif"));
imageRegistry.put(Constants.CONSOLE_IMAGE,
org.apache.qpid.management.ui.Activator.getImageDescriptor("/icons/qpidmc.gif"));
imageRegistry.put(Constants.CLOSED_FOLDER_IMAGE,
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/ApplicationWorkbenchWindowAdvisor.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/ApplicationWorkbenchWindowAdvisor.java?rev=794222&r1=794221&r2=794222&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/ApplicationWorkbenchWindowAdvisor.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/ApplicationWorkbenchWindowAdvisor.java Wed Jul 15 10:42:10 2009
@@ -51,7 +51,7 @@
int y = Display.getDefault().getBounds().height;
configurer.setInitialSize(new Point(9*x/10, 8*y/10));
configurer.setShowCoolBar(true);
- configurer.setShowStatusLine(false);
+ configurer.setShowStatusLine(true);
configurer.setTitle(Constants.APPLICATION_NAME);
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/Constants.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/Constants.java?rev=794222&r1=794221&r2=794222&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/Constants.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/Constants.java Wed Jul 15 10:42:10 2009
@@ -96,7 +96,10 @@
public final static String SUBSCRIBE_BUTTON = "Subscribe";
public final static String UNSUBSCRIBE_BUTTON = "Unsubscribe";
- public final static String CONSOLE_IMAGE = "ConsoelImage";
+
+ public final static String SUCCESS_IMAGE = "SuccessImage";
+ public final static String FAILURE_IMAGE = "FailureImage";
+ public final static String CONSOLE_IMAGE = "ConsoleImage";
public final static String CLOSED_FOLDER_IMAGE = "ClosedFolderImage";
public final static String OPEN_FOLDER_IMAGE = "OpenFolderImage";
public final static String MBEAN_IMAGE = "MBeanImage";
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/MBeanView.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/MBeanView.java?rev=794222&r1=794221&r2=794222&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/MBeanView.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/MBeanView.java Wed Jul 15 10:42:10 2009
@@ -32,12 +32,14 @@
import org.eclipse.jface.viewers.ISelection;
import org.eclipse.jface.viewers.IStructuredSelection;
import org.eclipse.swt.SWT;
+import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.layout.FormAttachment;
import org.eclipse.swt.layout.FormData;
import org.eclipse.swt.layout.FormLayout;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.TabFolder;
import org.eclipse.swt.widgets.TabItem;
+import org.eclipse.ui.IActionBars;
import org.eclipse.ui.ISelectionListener;
import org.eclipse.ui.IWorkbenchPart;
import org.eclipse.ui.forms.widgets.Form;
@@ -279,6 +281,8 @@
_typeTabFolder.setVisible(false);
createNotificationsTabFolder();
+
+ ViewUtility.setMBeanView(this);
}
private void refreshTab(TabItem tab)
@@ -380,6 +384,7 @@
}
_form.setText(APPLICATION_NAME);
+ populateStatusBar("");
}
public void mbeanUnregistered(ManagedBean mbean)
@@ -442,4 +447,15 @@
}
}
+ public void populateStatusBar(Image icon, String message)
+ {
+ IActionBars bars = getViewSite().getActionBars();
+ bars.getStatusLineManager().setMessage(icon, message);
+ }
+
+ public void populateStatusBar(String message)
+ {
+ IActionBars bars = getViewSite().getActionBars();
+ bars.getStatusLineManager().setMessage(message);
+ }
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/ViewUtility.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/ViewUtility.java?rev=794222&r1=794221&r2=794222&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/ViewUtility.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/ViewUtility.java Wed Jul 15 10:42:10 2009
@@ -40,6 +40,9 @@
import javax.management.openmbean.TabularType;
import org.apache.commons.codec.binary.Hex;
+import org.apache.qpid.management.ui.ApplicationRegistry;
+import static org.apache.qpid.management.ui.Constants.FAILURE_IMAGE;
+import static org.apache.qpid.management.ui.Constants.SUCCESS_IMAGE;
import org.eclipse.swt.SWT;
import org.eclipse.swt.events.ControlAdapter;
@@ -48,6 +51,7 @@
import org.eclipse.swt.events.SelectionEvent;
import org.eclipse.swt.events.SelectionListener;
import org.eclipse.swt.graphics.Font;
+import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.layout.GridData;
import org.eclipse.swt.layout.GridLayout;
import org.eclipse.swt.widgets.Button;
@@ -80,6 +84,8 @@
private static final Comparator tabularDataComparator = new TabularDataComparator();
+ private static MBeanView _mbeanView = null;
+
private static List<String> SUPPORTED_ARRAY_DATATYPES = new ArrayList<String>();
static
{
@@ -950,4 +956,51 @@
return -1;
}
}
+
+ public static void setMBeanView(MBeanView mbeanView)
+ {
+ _mbeanView = mbeanView;
+ }
+
+ /**
+ * Report feedback for the operation
+ * @param result true if success, false if unsuccessful, null if invoked but void result type.
+ * @param successMessage
+ * @param failureMessage
+ */
+ public static void operationResultFeedback(Boolean result, String successMessage, String failureMessage)
+ {
+ Image icon;
+
+ if(_mbeanView != null)
+ {
+ if(result == null)
+ {
+ icon = ApplicationRegistry.getImage(SUCCESS_IMAGE);
+ _mbeanView.populateStatusBar(icon, successMessage);
+ }
+ else if(result)
+ {
+ icon = ApplicationRegistry.getImage(SUCCESS_IMAGE);
+ _mbeanView.populateStatusBar(icon, successMessage);
+ }
+ else
+ {
+ icon = ApplicationRegistry.getImage(FAILURE_IMAGE);
+ _mbeanView.populateStatusBar(icon, failureMessage);
+ popupErrorMessage("Operation Failed", failureMessage);
+ }
+ }
+ }
+
+ public static void operationFailedStatusBarMessage(String failureMessage)
+ {
+ Image icon = ApplicationRegistry.getImage(FAILURE_IMAGE);
+
+ if(_mbeanView != null)
+ {
+ _mbeanView.populateStatusBar(icon, failureMessage);
+ }
+ }
+
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/connection/ConnectionOperationsTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/connection/ConnectionOperationsTabControl.java?rev=794222&r1=794221&r2=794222&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/connection/ConnectionOperationsTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/connection/ConnectionOperationsTabControl.java Wed Jul 15 10:42:10 2009
@@ -227,12 +227,14 @@
try
{
_cmb.commitTransactions(id);
+ ViewUtility.operationResultFeedback(null, "Commited transactions", null);
}
catch (Exception e1)
{
+ ViewUtility.operationFailedStatusBarMessage("Error commiting transactions");
MBeanUtility.handleException(_mbean, e1);
}
- //TODO:display result
+
refresh(_mbean);;
}
}
@@ -261,12 +263,14 @@
try
{
_cmb.rollbackTransactions(id);
+ ViewUtility.operationResultFeedback(null, "Rolled back transactions", null);
}
catch (Exception e1)
{
+ ViewUtility.operationFailedStatusBarMessage("Error rolling back transactions");
MBeanUtility.handleException(_mbean, e1);
}
- //TODO:display result
+
refresh(_mbean);;
}
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/ExchangeOperationsTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/ExchangeOperationsTabControl.java?rev=794222&r1=794221&r2=794222&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/ExchangeOperationsTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/ExchangeOperationsTabControl.java Wed Jul 15 10:42:10 2009
@@ -520,12 +520,13 @@
try
{
_emb.createNewBinding(destQueue, binding);
+ ViewUtility.operationResultFeedback(null, "Created new Binding", null);
}
catch (Exception e4)
{
+ ViewUtility.operationFailedStatusBarMessage("Error creating new Binding");
MBeanUtility.handleException(_mbean, e4);
}
- //TODO: display result?
refresh(_mbean);
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/HeadersExchangeOperationsTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/HeadersExchangeOperationsTabControl.java?rev=794222&r1=794221&r2=794222&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/HeadersExchangeOperationsTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/exchange/HeadersExchangeOperationsTabControl.java Wed Jul 15 10:42:10 2009
@@ -531,12 +531,13 @@
try
{
_emb.createNewBinding(destQueue, binding);
+ ViewUtility.operationResultFeedback(null, "Created new Binding", null);
}
catch (Exception e4)
{
+ ViewUtility.operationFailedStatusBarMessage("Error creating new Binding");
MBeanUtility.handleException(_mbean, e4);
}
- //TODO: display result?
refresh(_mbean);
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/ConfigurationFileTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/ConfigurationFileTabControl.java?rev=794222&r1=794221&r2=794222&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/ConfigurationFileTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/ConfigurationFileTabControl.java Wed Jul 15 10:42:10 2009
@@ -391,12 +391,14 @@
try
{
- _lmmb.setConfigFileLoggerLevel(logger, level);
- //TODO: display result?
+ boolean result = _lmmb.setConfigFileLoggerLevel(logger, level);
+ ViewUtility.operationResultFeedback(result,
+ "Updated ConfigFile Logger Level", "Failed to update ConfigFile Logger Level");
}
catch (Exception e4)
{
MBeanUtility.handleException(_mbean, e4);
+ ViewUtility.operationFailedStatusBarMessage("Error updating ConfigFile Logger Level");
}
refresh(_mbean);
@@ -448,11 +450,13 @@
shell.dispose();
try
{
- _lmmb.setConfigFileRootLoggerLevel(selection);
- //TODO: display result?
+ boolean result = _lmmb.setConfigFileRootLoggerLevel(selection);
+ ViewUtility.operationResultFeedback(result,
+ "Updated ConfigFile RootLogger Level", "Failed to update ConfigFile RootLogger Level");
}
catch (Exception e5)
{
+ ViewUtility.operationFailedStatusBarMessage("Error updating ConfigFile RootLogger Level");
MBeanUtility.handleException(_mbean, e5);
}
refresh(_mbean);
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/RuntimeTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/RuntimeTabControl.java?rev=794222&r1=794221&r2=794222&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/RuntimeTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/logging/RuntimeTabControl.java Wed Jul 15 10:42:10 2009
@@ -352,16 +352,18 @@
String level = levelCombo.getItem(levelCombo.getSelectionIndex()).toString();
shell.close();
-
+
try
{
- _lmmb.setRuntimeLoggerLevel(logger, level);
+ boolean result = _lmmb.setRuntimeLoggerLevel(logger, level);
+ ViewUtility.operationResultFeedback(result,
+ "Updated Runtime Logger Level", "Failed to update Runtime Logger Level");
}
catch(Exception e3)
{
+ ViewUtility.operationFailedStatusBarMessage("Error updating Runtime Logger Level");
MBeanUtility.handleException(_mbean, e3);
}
- //TODO: display result?
refresh(_mbean);
}
@@ -414,15 +416,17 @@
try
{
- _lmmb.setRuntimeRootLoggerLevel(selection);
+ boolean result = _lmmb.setRuntimeRootLoggerLevel(selection);
+ ViewUtility.operationResultFeedback(result,
+ "Updated Runtime RootLogger Level", "Failed to update Runtime Logger Level");
}
catch(Exception e4)
{
+ ViewUtility.operationFailedStatusBarMessage("Error updating Runtime Logger Level");
MBeanUtility.handleException(_mbean, e4);
}
refresh(_mbean);
- //TODO: display result?
}
});
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/queue/QueueOperationsTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/queue/QueueOperationsTabControl.java?rev=794222&r1=794221&r2=794222&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/queue/QueueOperationsTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/queue/QueueOperationsTabControl.java Wed Jul 15 10:42:10 2009
@@ -274,12 +274,14 @@
try
{
_qmb.clearQueue();
+ ViewUtility.operationResultFeedback(null, "Queue cleared", null);
}
catch (Exception e2)
{
+ ViewUtility.operationFailedStatusBarMessage("Error clearing Queue");
MBeanUtility.handleException(_mbean, e2);
}
- //TODO:display result
+
refresh(_mbean);;
}
}
@@ -596,12 +598,13 @@
_qmb.moveMessages(Long.valueOf(from), Long.valueOf(to), destQueue);
}
+ ViewUtility.operationResultFeedback(null, "Messages moved", null);
}
catch (Exception e4)
{
+ ViewUtility.operationFailedStatusBarMessage("Error moving messages");
MBeanUtility.handleException(_mbean, e4);
}
- //TODO: display result?
refresh(_mbean);
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/users/UserManagementTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/users/UserManagementTabControl.java?rev=794222&r1=794221&r2=794222&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/users/UserManagementTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/users/UserManagementTabControl.java Wed Jul 15 10:42:10 2009
@@ -233,13 +233,15 @@
{
try
{
- _ummb.deleteUser(user);
+ boolean result = _ummb.deleteUser(user);
+ ViewUtility.operationResultFeedback(result, "Deleted user", "Failed to delete user");
}
catch(Exception e1)
{
+ ViewUtility.operationFailedStatusBarMessage("Error deleting user");
MBeanUtility.handleException(_mbean, e1);
}
- //TODO:display result
+
refresh(_mbean);;
}
}
@@ -301,11 +303,12 @@
try
{
- _ummb.setPassword(user, password);
- //TODO display result
+ boolean result = _ummb.setPassword(user, password);
+ ViewUtility.operationResultFeedback(result, "Updated user password", "Failed to update user password");
}
catch(Exception e2)
{
+ ViewUtility.operationFailedStatusBarMessage("Error updating user password");
MBeanUtility.handleException(_mbean, e2);
}
}
@@ -394,11 +397,12 @@
{
try
{
- _ummb.reloadData();
- //TODO:display result
+ boolean result = _ummb.reloadData();
+ ViewUtility.operationResultFeedback(result, "Reloaded user data", "Failed to reload user data");
}
catch(Exception e3)
{
+ ViewUtility.operationFailedStatusBarMessage("Error reloading user data");
MBeanUtility.handleException(_mbean, e3);
}
refresh(_mbean);
@@ -588,11 +592,12 @@
shell.dispose();
try
{
- _ummb.setRights(user,read,write,admin);
- //TODO: display result?
+ boolean result = _ummb.setRights(user,read,write,admin);
+ ViewUtility.operationResultFeedback(result, "Updated user rights", "Failed to update user rights");
}
catch(Exception e4)
{
+ ViewUtility.operationFailedStatusBarMessage("Error setting user rights");
MBeanUtility.handleException(_mbean, e4);
}
refresh(_mbean);
@@ -686,11 +691,12 @@
shell.dispose();
try
{
- _ummb.createUser(username, password.toCharArray(), read, write, admin);
- //TODO: display result?
+ boolean result = _ummb.createUser(username, password.toCharArray(), read, write, admin);
+ ViewUtility.operationResultFeedback(result, "Created user", "Failed to create user");
}
catch(Exception e5)
{
+ ViewUtility.operationFailedStatusBarMessage("Error creating user");
MBeanUtility.handleException(_mbean, e5);
}
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/vhost/VHostTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/vhost/VHostTabControl.java?rev=794222&r1=794221&r2=794222&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/vhost/VHostTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/vhost/VHostTabControl.java Wed Jul 15 10:42:10 2009
@@ -232,15 +232,17 @@
{
_vhmb.deleteQueue(queue);
+ ViewUtility.operationResultFeedback(null, "Deleted Queue", null);
//remove queue from list of managed beans
ServerRegistry serverRegistry = ApplicationRegistry.getServerRegistry(MBeanView.getServer());
serverRegistry.removeManagedObject(selectedQueue);
}
catch(Exception e1)
{
+ ViewUtility.operationFailedStatusBarMessage("Error deleting Queue");
MBeanUtility.handleException(_mbean, e1);
}
- //TODO:display result
+
refresh(_mbean);;
}
}
@@ -355,15 +357,16 @@
{
_vhmb.unregisterExchange(exchange);
+ ViewUtility.operationResultFeedback(null, "Deleted Exchange", null);
//remove exchange from list of managed beans
ServerRegistry serverRegistry = ApplicationRegistry.getServerRegistry(MBeanView.getServer());
serverRegistry.removeManagedObject(selectedExchange);
}
catch(Exception e1)
{
+ ViewUtility.operationFailedStatusBarMessage("Error deleting Exchange");
MBeanUtility.handleException(_mbean, e1);
}
- //TODO:display result
refresh(_mbean);;
}
@@ -564,8 +567,8 @@
try
{
_vhmb.createNewQueue(name, owner, durable);
- //TODO: display result?
+ ViewUtility.operationResultFeedback(null, "Created Queue", null);
try
{
//delay to allow mbean registration notification processing
@@ -578,6 +581,7 @@
}
catch(Exception e5)
{
+ ViewUtility.operationFailedStatusBarMessage("Error creating Queue");
MBeanUtility.handleException(_mbean, e5);
}
@@ -673,8 +677,8 @@
try
{
_vhmb.createNewExchange(name, type, durable);
- //TODO: display result?
-
+
+ ViewUtility.operationResultFeedback(null, "Created Exchange", null);
try
{
//delay to allow mbean registration notification processing
@@ -687,6 +691,7 @@
}
catch(Exception e5)
{
+ ViewUtility.operationFailedStatusBarMessage("Error creating Exchange");
MBeanUtility.handleException(_mbean, e5);
}
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org