You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/05/13 21:53:00 UTC

[GitHub] [pulsar] jerrypeng commented on issue #4223: Make Function submission checks optional

jerrypeng commented on issue #4223: Make Function submission checks optional
URL: https://github.com/apache/pulsar/pull/4223#issuecomment-492000929
 
 
   @srkukarni the PR in general looks fine since we really need to not load JARs in the worker/broker for security purposes.  I just have a few comments. However, the current validation logic is very complicated, hard to follow, and some methods are poorly named.  We should in the future, refactor the validation code.
   
   Can we also have some unit/integration tests to test switching on and off the validation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services