You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/11/11 01:15:39 UTC

[GitHub] [incubator-ratis] szetszwo commented on a change in pull request #267: RATIS-1145. In NettyServerStreamRpc, the local/remote writes should only wait for the previous write.

szetszwo commented on a change in pull request #267:
URL: https://github.com/apache/incubator-ratis/pull/267#discussion_r520985260



##########
File path: ratis-server/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java
##########
@@ -410,7 +410,7 @@ static void setRetentionFileNum(RaftProperties properties, int numSnapshotFilesR
     String PREFIX = RaftServerConfigKeys.PREFIX + ".data-stream";
 
     String ASYNC_THREAD_POOL_SIZE_KEY = PREFIX + ".async.thread.pool.size";
-    int ASYNC_THREAD_POOL_SIZE_DEFAULT = 4;
+    int ASYNC_THREAD_POOL_SIZE_DEFAULT = 16;

Review comment:
       Choose 16 for a value close to the number of cores of a machine; 4 seems too small.  For large value like 500, it might be good for application like Ozone but the value is too large for general applications.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org