[GitHub] reminisce commented on a change in pull request #10150: [WIP] [DO NOT MERGE] Sparse operator broadcast_mul/div(csr, dense) = csr

[GitBox <gi...@apache.org>]

reminisce commented on a change in pull request #10150: [WIP] [DO NOT MERGE] Sparse operator broadcast_mul/div(csr, dense) = csr
URL: https://github.com/apache/incubator-mxnet/pull/10150#discussion_r175506928
 
 

 ##########
 File path: src/operator/tensor/elemwise_binary_broadcast_op.h
 ##########
 @@ -155,6 +181,22 @@ struct binary_broadcast_kernel {
     }
   }
 };
+
+template<typename DType, typename CType, typename RType, int req, typename OP>
 
 Review comment:
   Agree with applying these as function's template arguments instead of the class's.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services