You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/07 22:15:45 UTC

[GitHub] [tvm] jroesch commented on pull request #8926: Fix incorrect AOT Memory Planning

jroesch commented on pull request #8926:
URL: https://github.com/apache/tvm/pull/8926#issuecomment-914663405


   > Overall, LGTM! I'd like to see CalculateWorkspaceBytes in a pass in the future instead of being run directly in the exectutor, but this is fine for now
   
   @Mousius is it possible for you guys to put this as a backlog item? will land this version but in general better to try and split these things into passes so we can make the executor code gens function more uniform instead of each one having different arguments/return values, etc. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org