[GitHub] [arrow] wjones127 commented on a change in pull request #11956: ARROW-10456: [R] Implement MapType

[GitBox <gi...@apache.org>]

wjones127 commented on a change in pull request #11956:
URL: https://github.com/apache/arrow/pull/11956#discussion_r773374201



##########
File path: r/src/symbols.cpp
##########
@@ -75,6 +75,10 @@ SEXP data::classes_arrow_large_list = precious(cpp11::writable::strings(
 SEXP data::classes_arrow_fixed_size_list = precious(cpp11::writable::strings(
     {"arrow_fixed_size_list", "vctrs_list_of", "vctrs_vctr", "list"}));
 
+// TODO: do we even need this?
+SEXP data::classes_arrow_map = precious(
+    cpp11::writable::strings({"arrow_map", "arrow_list", "vctrs_list_of", "vctrs_vctr", "list"}));
+

Review comment:
       I'm a little confused on what this does, and if I need it. Arrow's maps are just lists of structs with some extra validation. What behavior does this affect? How is it tested?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org