You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2013/01/22 20:42:30 UTC
svn commit: r1437119 -
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
Author: stack
Date: Tue Jan 22 19:42:30 2013
New Revision: 1437119
URL: http://svn.apache.org/viewvc?rev=1437119&view=rev
Log:
HBASE-7588 Fix two findbugs warning in MemStoreFlusher
Modified:
hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java?rev=1437119&r1=1437118&r2=1437119&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java Tue Jan 22 19:42:30 2013
@@ -20,6 +20,7 @@ package org.apache.hadoop.hbase.regionse
import java.io.IOException;
import java.lang.management.ManagementFactory;
+import java.util.Arrays;
import java.util.ConcurrentModificationException;
import java.util.HashMap;
import java.util.HashSet;
@@ -44,6 +45,7 @@ import org.apache.hadoop.hbase.RemoteExc
import org.apache.hadoop.hbase.util.Bytes;
import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
import org.apache.hadoop.hbase.util.HasThread;
+import org.apache.hadoop.hbase.util.HashedBytes;
import org.apache.hadoop.util.StringUtils;
import org.cliffc.high_scale_lib.Counter;
@@ -530,6 +532,12 @@ class MemStoreFlusher extends HasThread
public int compareTo(Delayed o) {
return -1;
}
+
+ @Override
+ public boolean equals(Object obj) {
+ return (this == obj);
+ }
+
}
/**
@@ -592,10 +600,21 @@ class MemStoreFlusher extends HasThread
return Long.valueOf(getDelay(TimeUnit.MILLISECONDS) -
other.getDelay(TimeUnit.MILLISECONDS)).intValue();
}
+
@Override
public String toString() {
return "[flush region " + Bytes.toStringBinary(region.getRegionName()) + "]";
}
+
+ @Override
+ public boolean equals(Object obj) {
+ if (this == obj)
+ return true;
+ if (obj == null || getClass() != obj.getClass())
+ return false;
+ Delayed other = (Delayed) obj;
+ return compareTo(other) == 0;
+ }
}
}