You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mintsweet (via GitHub)" <gi...@apache.org> on 2023/02/16 09:31:51 UTC
[GitHub] [incubator-devlake] mintsweet opened a new pull request, #4434: feat(config-ui): support plugin sonarqube
mintsweet opened a new pull request, #4434:
URL: https://github.com/apache/incubator-devlake/pull/4434
### Summary
What does this PR do?
### Does this close any open issues?
Closes xx
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh merged pull request #4434: feat(config-ui): support plugin sonarqube
Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh merged PR #4434:
URL: https://github.com/apache/incubator-devlake/pull/4434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4434: feat(config-ui): support plugin sonarqube
Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh commented on code in PR #4434:
URL: https://github.com/apache/incubator-devlake/pull/4434#discussion_r1109366519
##########
config-ui/src/plugins/register/sonarqube/config.ts:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+import type { PluginConfigType } from '@/plugins';
+import { PluginType } from '@/plugins';
+
+import Icon from './assets/icon.svg';
+
+export const SonarQubeConfig: PluginConfigType = {
+ type: PluginType.Connection,
+ plugin: 'sonarqube',
+ name: 'SonarQube',
+ icon: Icon,
+ sort: 7,
+ connection: {
+ docLink: '',
+ fields: [
+ 'name',
+ 'endpoint',
+ 'token',
+ 'proxy',
+ {
+ key: 'rateLimitPerHour',
+ subLabel:
+ 'By default, DevLake uses 18,000 requests/hour for data collection for Azure DevOps. But you can adjust the collection speed by setting up your desirable rate limit.',
+ learnMore: 'https://devlake.apache.org/docs/UserManuals/ConfigUI/AzureDevOps/#custom-rate-limit-optional',
+ externalInfo: 'Azure DevOps does not specify a maximum value of rate limit.',
+ maximum: 18000,
Review Comment:
maximum? what's difference between defaultValue and maximum?
##########
config-ui/src/plugins/register/sonarqube/config.ts:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+import type { PluginConfigType } from '@/plugins';
+import { PluginType } from '@/plugins';
+
+import Icon from './assets/icon.svg';
+
+export const SonarQubeConfig: PluginConfigType = {
+ type: PluginType.Connection,
+ plugin: 'sonarqube',
+ name: 'SonarQube',
+ icon: Icon,
+ sort: 7,
+ connection: {
+ docLink: '',
+ fields: [
+ 'name',
+ 'endpoint',
+ 'token',
+ 'proxy',
+ {
+ key: 'rateLimitPerHour',
+ subLabel:
+ 'By default, DevLake uses 18,000 requests/hour for data collection for Azure DevOps. But you can adjust the collection speed by setting up your desirable rate limit.',
+ learnMore: 'https://devlake.apache.org/docs/UserManuals/ConfigUI/AzureDevOps/#custom-rate-limit-optional',
+ externalInfo: 'Azure DevOps does not specify a maximum value of rate limit.',
+ maximum: 18000,
Review Comment:
maximum? what difference between defaultValue and maximum?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #4434: feat(config-ui): support plugin sonarqube
Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet commented on code in PR #4434:
URL: https://github.com/apache/incubator-devlake/pull/4434#discussion_r1109370885
##########
config-ui/src/plugins/register/sonarqube/config.ts:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+import type { PluginConfigType } from '@/plugins';
+import { PluginType } from '@/plugins';
+
+import Icon from './assets/icon.svg';
+
+export const SonarQubeConfig: PluginConfigType = {
+ type: PluginType.Connection,
+ plugin: 'sonarqube',
+ name: 'SonarQube',
+ icon: Icon,
+ sort: 7,
+ connection: {
+ docLink: '',
+ fields: [
+ 'name',
+ 'endpoint',
+ 'token',
+ 'proxy',
+ {
+ key: 'rateLimitPerHour',
+ subLabel:
+ 'By default, DevLake uses 18,000 requests/hour for data collection for Azure DevOps. But you can adjust the collection speed by setting up your desirable rate limit.',
+ learnMore: 'https://devlake.apache.org/docs/UserManuals/ConfigUI/AzureDevOps/#custom-rate-limit-optional',
+ externalInfo: 'Azure DevOps does not specify a maximum value of rate limit.',
+ maximum: 18000,
Review Comment:
the rate limit default value is 0, but enabled will set another value, **maximum** is this value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org