You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/11/15 04:17:55 UTC
[GitHub] [incubator-kyuubi] turboFei opened a new pull request #1382: Sync flink-provided profile
turboFei opened a new pull request #1382:
URL: https://github.com/apache/incubator-kyuubi/pull/1382
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1382: Sync the flink-provided profile in docs and testing suite comments
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1382:
URL: https://github.com/apache/incubator-kyuubi/pull/1382#issuecomment-968540562
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1382](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2ca596d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/1554032df2576695f6345232dc61c0162644aec3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1554032) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1382 +/- ##
=========================================
Coverage 79.14% 79.14%
Complexity 110 110
=========================================
Files 182 182
Lines 7671 7671
Branches 936 936
=========================================
Hits 6071 6071
Misses 1093 1093
Partials 507 507
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1554032...2ca596d](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1382: Sync the flink-provided profile in docs and testing suite comments
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-kyuubi/pull/1382#discussion_r749181796
##########
File path: .github/workflows/master.yml
##########
@@ -54,7 +54,7 @@ jobs:
- java: 11
spark: '3.1'
spark-hadoop: '3.2'
- profiles: '-DskipTests -Pspark-provided'
+ profiles: '-DskipTests -Pflink-provided -Pspark-provided'
Review comment:
let's concat them by ,
##########
File path: .github/workflows/publish-snapshot.yml
##########
@@ -37,14 +37,14 @@ jobs:
ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
run: |
rm -rf ~/.m2/repository/org/apache/kyuubi
- ./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pspark-provided
- ./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pspark-provided,spark-3.1 -pl dev/kyuubi-extension-spark-3-1 -am
- ./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pspark-provided,spark-3.2 -pl dev/kyuubi-extension-spark-3-2 -am
+ ./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pflink-provided -Pspark-provided
+ ./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pflink-provided -Pspark-provided,spark-3.1 -pl dev/kyuubi-extension-spark-3-1 -am
+ ./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pflink-provided -Pspark-provided,spark-3.2 -pl dev/kyuubi-extension-spark-3-2 -am
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1382: Sync the flink-provided profile in docs and testing suite comments
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1382:
URL: https://github.com/apache/incubator-kyuubi/pull/1382#issuecomment-968540562
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1382](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7229481) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/1554032df2576695f6345232dc61c0162644aec3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1554032) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7229481 differs from pull request most recent head 2ca596d. Consider uploading reports for the commit 2ca596d to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1382 +/- ##
============================================
+ Coverage 79.14% 79.15% +0.01%
Complexity 110 110
============================================
Files 182 182
Lines 7671 7671
Branches 936 936
============================================
+ Hits 6071 6072 +1
Misses 1093 1093
+ Partials 507 506 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `90.90% <0.00%> (+1.01%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1554032...2ca596d](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #1382: Sync the flink-provided profile in docs and testing suite comments
Posted by GitBox <gi...@apache.org>.
turboFei commented on pull request #1382:
URL: https://github.com/apache/incubator-kyuubi/pull/1382#issuecomment-983558886
addressed the comments and will merge it after GA passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1382: Sync the flink-provided profile in docs and testing suite comments
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-kyuubi/pull/1382#discussion_r748994812
##########
File path: .github/workflows/master.yml
##########
@@ -54,7 +54,7 @@ jobs:
- java: 11
spark: '3.1'
spark-hadoop: '3.2'
- profiles: '-DskipTests -Pspark-provided'
+ profiles: '-DskipTests -Pspark-provided -Pflink-provided'
Review comment:
'-Pspark-provided -Pflink-provided' => '-Pflink-provided,spark-provided'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1382: Sync the flink-provided profile in docs and testing suite comments
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-kyuubi/pull/1382#discussion_r749181970
##########
File path: .github/workflows/publish-snapshot.yml
##########
@@ -37,14 +37,14 @@ jobs:
ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
run: |
rm -rf ~/.m2/repository/org/apache/kyuubi
- ./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pspark-provided
- ./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pspark-provided,spark-3.1 -pl dev/kyuubi-extension-spark-3-1 -am
- ./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pspark-provided,spark-3.2 -pl dev/kyuubi-extension-spark-3-2 -am
+ ./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pflink-provided -Pspark-provided
+ ./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pflink-provided -Pspark-provided,spark-3.1 -pl dev/kyuubi-extension-spark-3-1 -am
+ ./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pflink-provided -Pspark-provided,spark-3.2 -pl dev/kyuubi-extension-spark-3-2 -am
- name: Publish snapshot - branch-1.3
if: ${{ matrix.branch == 'branch-1.3' }}
env:
ASF_USERNAME: ${{ secrets.NEXUS_USER }}
ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
run: |
rm -rf ~/.m2/repository/org/apache/kyuubi
- ./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pspark-provided,kyuubi-extension-spark-3-1
+ ./build/mvn clean deploy -s ./build/release/asf-settings.xml -DskipTests -Pflink-provided -Pspark-provided,kyuubi-extension-spark-3-1
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1382: Sync the flink-provided profile in docs and testing suite comments
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1382:
URL: https://github.com/apache/incubator-kyuubi/pull/1382#issuecomment-968540562
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1382](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2ca596d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/ac24c8fb8cff6fea71214a20e9fd0eb2b8a97365?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ac24c8f) will **increase** coverage by `20.25%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 2ca596d differs from pull request most recent head 3ae9696. Consider uploading reports for the commit 3ae9696 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1382 +/- ##
=============================================
+ Coverage 58.88% 79.14% +20.25%
+ Complexity 155 110 -45
=============================================
Files 232 182 -50
Lines 11931 7671 -4260
Branches 1460 936 -524
=============================================
- Hits 7026 6071 -955
+ Misses 4313 1093 -3220
+ Partials 592 507 -85
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ubi/sql/zorder/InsertZorderBeforeWritingBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvSW5zZXJ0Wm9yZGVyQmVmb3JlV3JpdGluZ0Jhc2Uuc2NhbGE=) | `82.27% <0.00%> (-6.88%)` | :arrow_down: |
| [...ubi/server/KyuubiThriftBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpVGhyaWZ0QmluYXJ5RnJvbnRlbmRTZXJ2aWNlLnNjYWxh) | `90.00% <0.00%> (-6.67%)` | :arrow_down: |
| [...ala/org/apache/kyuubi/operation/LaunchEngine.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vTGF1bmNoRW5naW5lLnNjYWxh) | `80.95% <0.00%> (-5.42%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `79.48% <0.00%> (-4.73%)` | :arrow_down: |
| [...rg/apache/kyuubi/operation/AbstractOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vQWJzdHJhY3RPcGVyYXRpb24uc2NhbGE=) | `66.03% <0.00%> (-3.46%)` | :arrow_down: |
| [.../authentication/KyuubiDelegationTokenManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaURlbGVnYXRpb25Ub2tlbk1hbmFnZXIuc2NhbGE=) | `87.50% <0.00%> (-3.41%)` | :arrow_down: |
| [...he/kyuubi/engine/spark/shim/CatalogShim\_v2\_4.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zaGltL0NhdGFsb2dTaGltX3YyXzQuc2NhbGE=) | `75.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `40.71% <0.00%> (-3.16%)` | :arrow_down: |
| [...che/kyuubi/server/KyuubiMySQLFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpTXlTUUxGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `87.71% <0.00%> (-2.76%)` | :arrow_down: |
| [...uubi/engine/spark/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `85.39% <0.00%> (-2.24%)` | :arrow_down: |
| ... and [135 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ac24c8f...3ae9696](https://codecov.io/gh/apache/incubator-kyuubi/pull/1382?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei closed pull request #1382: Sync the flink-provided profile in docs and testing suite comments
Posted by GitBox <gi...@apache.org>.
turboFei closed pull request #1382:
URL: https://github.com/apache/incubator-kyuubi/pull/1382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1382: Sync the flink-provided profile in docs and testing suite comments
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-kyuubi/pull/1382#discussion_r749006434
##########
File path: docs/develop_tools/distribution.md
##########
@@ -48,10 +49,10 @@ For instance,
This results in a Kyuubi distribution named `kyuubi-{version}-bin-custom-name.tgz` for you.
-If you are planing to deploy Kyuubi where `spark` is provided, in other word, it's not required to bundle spark binary, use
+If you are planing to deploy Kyuubi where `spark`/`flink` is provided, in other word, it's not required to bundle spark/flink binary, use
```bash
-./build/dist --tgz --spark-provided
+./build/dist --tgz --spark-provided --flink-provided
Review comment:
keep the order as before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1382: Sync the flink-provided profile in docs and testing suite comments
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1382:
URL: https://github.com/apache/incubator-kyuubi/pull/1382#issuecomment-970185370
shall we merge this PR after cut branch-1.4 ? since flink is tagged to 1.5.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #1382: Sync the flink-provided profile in docs and testing suite comments
Posted by GitBox <gi...@apache.org>.
turboFei commented on pull request #1382:
URL: https://github.com/apache/incubator-kyuubi/pull/1382#issuecomment-983597054
thanks for your review, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org