[jira] [Commented] (LUCENE-5726) Make all resourceDescriptions of indexinputs consistent

["Robert Muir (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015668#comment-14015668 ] 

Robert Muir commented on LUCENE-5726:
-------------------------------------

I think for this issue, the trick is to make CompoundFileDirectory not pass just the filename (_1.fdt) as the resource description, but instead something more complex. it should be a nicely named string that makes it clear its a CFS slice (ideally including the original handle description completely).

I think its ok to build a good string here, because this is not called per query or anything. We can enhance the javadocs of slice() to say that the caller is responsible for passing the description in or something like that (caller has the original indexinput to toString() if it wants to use that).


> Make all resourceDescriptions of indexinputs consistent
> -------------------------------------------------------
>
>                 Key: LUCENE-5726
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5726
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>
> This was weakly tested in a roundabout way by an assert that tried to read a lucene 2.x index.
> We should try to make these consistent, on the other hand we should be careful about keeping the overhead of slice() relatively low (it would be nice to use this api in more places).
> And such things should be tested elsewhere, e.g. BaseDirectoryTestCase



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org