You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Swapnil Bawaskar <sb...@apache.org> on 2016/03/15 02:28:11 UTC
Review Request 44821: GEODE-1099: NPE thrown from
TXManagerImpl.isDistributed()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44821/
-----------------------------------------------------------
Review request for geode and Darrel Schneider.
Repository: geode
Description
-------
Use the existing reference to InternalDistributedSystem so as to prevent a NPE.
If the member is indeed being disconnected, a CacheClosed exception is thrown
while trying to send the message.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java de49fead8e0188d6b1316e1bc37d05d452cb9de5
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplJUnitTest.java a92d4dc52392f86d439bb0b3cafc4cf20cc0732e
Diff: https://reviews.apache.org/r/44821/diff/
Testing
-------
Thanks,
Swapnil Bawaskar
Re: Review Request 44821: GEODE-1099: NPE thrown from
TXManagerImpl.isDistributed()
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44821/#review123677
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On March 14, 2016, 6:28 p.m., Swapnil Bawaskar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44821/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 6:28 p.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Use the existing reference to InternalDistributedSystem so as to prevent a NPE.
> If the member is indeed being disconnected, a CacheClosed exception is thrown
> while trying to send the message.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java de49fead8e0188d6b1316e1bc37d05d452cb9de5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplJUnitTest.java a92d4dc52392f86d439bb0b3cafc4cf20cc0732e
>
> Diff: https://reviews.apache.org/r/44821/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Swapnil Bawaskar
>
>
Re: Review Request 44821: GEODE-1099: NPE thrown from
TXManagerImpl.isDistributed()
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44821/#review123890
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On March 16, 2016, 5:32 p.m., Swapnil Bawaskar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44821/
> -----------------------------------------------------------
>
> (Updated March 16, 2016, 5:32 p.m.)
>
>
> Review request for geode, Darrel Schneider and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Use the existing reference to InternalDistributedSystem so as to prevent a NPE.
> If the member is indeed being disconnected, a CacheClosed exception is thrown
> while trying to send the message.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistTXManagerImplJUnitTest.java 1df2c452daf79364e1d61138d6f75164cb7b1eda
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplJUnitTest.java 0467f4fde5c888294dbf197974c62676f3378b37
>
> Diff: https://reviews.apache.org/r/44821/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Swapnil Bawaskar
>
>
Re: Review Request 44821: GEODE-1099: NPE thrown from
TXManagerImpl.isDistributed()
Posted by Swapnil Bawaskar <sb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44821/
-----------------------------------------------------------
(Updated March 16, 2016, 5:32 p.m.)
Review request for geode, Darrel Schneider and Dan Smith.
Changes
-------
Fixing DistTXManagerImplJUnitTest
Repository: geode
Description
-------
Use the existing reference to InternalDistributedSystem so as to prevent a NPE.
If the member is indeed being disconnected, a CacheClosed exception is thrown
while trying to send the message.
Diffs (updated)
-----
geode-core/src/test/java/com/gemstone/gemfire/disttx/DistTXManagerImplJUnitTest.java 1df2c452daf79364e1d61138d6f75164cb7b1eda
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplJUnitTest.java 0467f4fde5c888294dbf197974c62676f3378b37
Diff: https://reviews.apache.org/r/44821/diff/
Testing
-------
Thanks,
Swapnil Bawaskar