[GitHub] [arrow-datafusion] mpurins-coralogix commented on a diff in pull request #5497: Allow setting config extensions for TaskContext

["mpurins-coralogix (via GitHub)" <gi...@apache.org>]

mpurins-coralogix commented on code in PR #5497:
URL: https://github.com/apache/arrow-datafusion/pull/5497#discussion_r1127937243


##########
datafusion/common/src/config.rs:
##########
@@ -397,6 +397,13 @@ impl ConfigOptions {
         Self::default()
     }
 
+    /// Creates a new [`ConfigOptions`] with extensions set to provided value
+    pub fn with_extensions(extensions: Extensions) -> Self {

Review Comment:
   Would with builder api it would initially create one redundant instance of `Extensions`?
   
   Anyway it likely doesn't really matter and I agree that it would be nicer to use. Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org