You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/12 12:00:42 UTC
[GitHub] [spark] tanelk opened a new pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame API
tanelk opened a new pull request #33723:
URL: https://github.com/apache/spark/pull/33723
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Move the `RemoveLiteralFromGroupExpressions` and `RemoveRepetitionFromGroupExpressions` rules from a separate batch to the `operatorOptimizationBatch`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The `RemoveLiteralFromGroupExpressions` does not work in some cases if it is in a separate batch.
The added UT would fail with:
```
[info] - SPARK-36496: Remove literals from grouping expressions *** FAILED *** (2 seconds, 955 milliseconds)
[info] == FAIL: Plans do not match ===
[info] !Aggregate [*id#0L, null], [*id#0L, null AS a#0, count(1) AS count#0L] Aggregate [*id#0L], [*id#0L, null AS a#0, count(1) AS count#0L]
[info] +- Range (0, 100, step=1, splits=Some(2)) +- Range (0, 100, step=1, splits=Some(2)) (PlanTest.scala:174)
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
New UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-900034196
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47037/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-897589712
**[Test build #142381 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142381/testReport)** for PR 33723 at commit [`c7dfb3c`](https://github.com/apache/spark/commit/c7dfb3c5839b95790644b29d5fdc7de3cbd802bf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-946537164
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48878/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-946537113
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48878/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-946488150
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48878/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-897815201
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142381/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-946537164
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48878/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-900013805
**[Test build #142536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142536/testReport)** for PR 33723 at commit [`38d98ed`](https://github.com/apache/spark/commit/38d98ed9e613f181018bb6266d89ab772db84b4c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-900191361
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142536/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-900054789
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47037/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-897627698
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46888/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-946449776
**[Test build #144405 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144405/testReport)** for PR 33723 at commit [`d67a3f0`](https://github.com/apache/spark/commit/d67a3f0483b23d99e0752278d01acebab73fbc70).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk closed pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
tanelk closed pull request #33723:
URL: https://github.com/apache/spark/pull/33723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-897589712
**[Test build #142381 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142381/testReport)** for PR 33723 at commit [`c7dfb3c`](https://github.com/apache/spark/commit/c7dfb3c5839b95790644b29d5fdc7de3cbd802bf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-897627698
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46888/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-946449817
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144405/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-900191361
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142536/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-897808872
**[Test build #142381 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142381/testReport)** for PR 33723 at commit [`c7dfb3c`](https://github.com/apache/spark/commit/c7dfb3c5839b95790644b29d5fdc7de3cbd802bf).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-900188599
**[Test build #142536 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142536/testReport)** for PR 33723 at commit [`38d98ed`](https://github.com/apache/spark/commit/38d98ed9e613f181018bb6266d89ab772db84b4c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class SessionWindow(timeColumn: Expression, gapDuration: Expression) extends Expression`
* `case class UnresolvedWith(`
* `case class CTERelationDef(child: LogicalPlan, id: Long = CTERelationDef.newId) extends UnaryNode `
* `case class CTERelationRef(`
* `case class WithCTE(plan: LogicalPlan, cteDefs: Seq[CTERelationDef]) extends LogicalPlan `
* `class DefaultDateFormatter(`
* `class DefaultTimestampFormatter(`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-897617626
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46888/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-946449817
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144405/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-946445727
**[Test build #144405 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144405/testReport)** for PR 33723 at commit [`d67a3f0`](https://github.com/apache/spark/commit/d67a3f0483b23d99e0752278d01acebab73fbc70).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-900059529
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47037/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-900059529
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47037/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-900013805
**[Test build #142536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142536/testReport)** for PR 33723 at commit [`38d98ed`](https://github.com/apache/spark/commit/38d98ed9e613f181018bb6266d89ab772db84b4c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-900013436
pinging @maropu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-897815201
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142381/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33723: [SPARK-36496][SQL] Remove literals from grouping expressions when using the DataFrame withColumn API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33723:
URL: https://github.com/apache/spark/pull/33723#issuecomment-946445727
**[Test build #144405 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144405/testReport)** for PR 33723 at commit [`d67a3f0`](https://github.com/apache/spark/commit/d67a3f0483b23d99e0752278d01acebab73fbc70).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org