You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by mattf-horton <gi...@git.apache.org> on 2017/05/03 20:42:06 UTC
[GitHub] incubator-metron pull request #564: Metron-905 Fix square-bracket behavior a...
GitHub user mattf-horton opened a pull request:
https://github.com/apache/incubator-metron/pull/564
Metron-905 Fix square-bracket behavior and default network interface bindings for ES
## Contributor Comments
Changes as specified in email thread and METRON-905:
1. Document network.host parameter with ref to ES docs.
2. Add network.publish_host parameter, default empty, with same docs ref.
3. For single-node and QuickDev deployments, set the default value of network.host to [ _local_ ] .
4. For multi-node and FullDev, set the default value to [ _local_, _site_ ] .
5. For generic ambari install, set the default value to [ _local_ ] but document this is for single-node installs, and for cluster installs it must be changed to add _site_ .
6. For network_host and zen_discovery_ping_unicast_hosts, require that brackets and quotes be provided explicitly as part of the config value, consistent with ES config requirements.
I wanted to get the code changes out for shared testing soonest. I will add some docs changes to the PR, at the README level.
This needs to be tested against each of our deployment modes:
* QuickDev
* FullDev
* bare-metal Ambari, single node
* bare-metal Ambari, multi-node (with manual change to default network_host value)
* EC2
* Vagrant/Ansible?
* a multi-homed cluster, with non-empty network_publish_host ( @JonZeolla ?)
* Other?
Volunteers are humbly begged to claim and exercise one or more.
In each configuration, one should see ES come up, without errors in Ambari, and without configuration exceptions in elasticsearch logs (/var/log/elasticsearch/metron.log, in Centos7) on any ES host.
## Pull Request Checklist
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [IN PROCESS] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [NA] Have you written or updated unit tests and or integration tests to verify your changes?
- [NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [IN PROCESS] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattf-horton/incubator-metron METRON-905
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/564.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #564
----
commit 3aae36dda70c4017ecb707381dbbd44af5988feb
Author: mattf-horton <mf...@hortonworks.com>
Date: 2017-05-02T17:22:06Z
METRON-905 Fix square-brackets and use 0.0.0.0 for default network interface bindings for ES. Not yet implemented 'tolerance' for square brackets.
commit cb13e824da480fd56e043019bcb7a06723b1cb72
Author: mattf-horton <mf...@hortonworks.com>
Date: 2017-05-03T17:48:57Z
Revert "METRON-905 Fix square-brackets and use 0.0.0.0 for default network interface bindings for ES. Not yet implemented 'tolerance' for square brackets."
This reverts commit e879719a0c3fb1e327455b2656a944b19e873566.
commit d7b464708d1aa2ebb4a000b5051a5e39b7984ebd
Author: mattf-horton <mf...@hortonworks.com>
Date: 2017-05-03T20:06:16Z
METRON-905 Fix square-bracket behavior and default network interface bindings for ES
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #564: Metron-905 Fix square-bracket behavior and defa...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/564
@mattf-horton I will test this on EC2. I am going to also test #563 at the same time.
Thanks so much for fixing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #564: Metron-905 Fix square-bracket behavior a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-metron/pull/564
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #564: Metron-905 Fix square-bracket behavior a...
Posted by JonZeolla <gi...@git.apache.org>.
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/564#discussion_r115301858
--- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/configuration/elastic-site.xml ---
@@ -189,7 +189,12 @@
</property>
<property>
<name>network_host</name>
- <value>"_lo:ipv4_","_eth0:ipv4_"</value>
- <description>Network interface(s) ES will bind to within each node. Confirm names via ifconfig. Should have entries for primary external and loopback interfaces, with :ipv4 annotation and quote marks around each entry: "_lo:ipv4_","_eth0:ipv4_"</description>
+ <value>[ _local_ ]</value>
+ <description>Network interface(s) ES will bind to within each node. Use [ _local_ ] for single-node install; change to [ _local_, _site_ ] (including square brackets) for typical cluster install. See https://www.elastic.co/guide/en/elasticsearch/reference/2.3/modules-network.html for ES documentation.</description>
+ </property>
+ <property>
+ <name>network_publish_host</name>
--- End diff --
Shouldn't we just change it to be optional, if it's actually optional?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #564: Metron-905 Fix square-bracket behavior a...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/564#discussion_r115499529
--- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/configuration/elastic-site.xml ---
@@ -189,7 +189,12 @@
</property>
<property>
<name>network_host</name>
- <value>"_lo:ipv4_","_eth0:ipv4_"</value>
- <description>Network interface(s) ES will bind to within each node. Confirm names via ifconfig. Should have entries for primary external and loopback interfaces, with :ipv4 annotation and quote marks around each entry: "_lo:ipv4_","_eth0:ipv4_"</description>
+ <value>[ _local_ ]</value>
+ <description>Network interface(s) ES will bind to within each node. Use [ _local_ ] for single-node install; change to [ _local_, _site_ ] (including square brackets) for typical cluster install. See https://www.elastic.co/guide/en/elasticsearch/reference/2.3/modules-network.html for ES documentation.</description>
+ </property>
+ <property>
+ <name>network_publish_host</name>
--- End diff --
That did it! I ran it up on EC2 and it worked as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #564: Metron-905 Fix square-bracket behavior a...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/564#discussion_r115272704
--- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/configuration/elastic-site.xml ---
@@ -189,7 +189,12 @@
</property>
<property>
<name>network_host</name>
- <value>"_lo:ipv4_","_eth0:ipv4_"</value>
- <description>Network interface(s) ES will bind to within each node. Confirm names via ifconfig. Should have entries for primary external and loopback interfaces, with :ipv4 annotation and quote marks around each entry: "_lo:ipv4_","_eth0:ipv4_"</description>
+ <value>[ _local_ ]</value>
+ <description>Network interface(s) ES will bind to within each node. Use [ _local_ ] for single-node install; change to [ _local_, _site_ ] (including square brackets) for typical cluster install. See https://www.elastic.co/guide/en/elasticsearch/reference/2.3/modules-network.html for ES documentation.</description>
+ </property>
+ <property>
+ <name>network_publish_host</name>
--- End diff --
The only potential issue I see is with "network_publish_host". Ambari treats that as a required field, but it is not populated by default. So I cannot change any other ES configuration value unless I define this field to something.
Is this what you would expect? Is there some safe default that we can set this to instead of being empty?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #564: Metron-905 Fix square-bracket behavior a...
Posted by mattf-horton <gi...@git.apache.org>.
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/564#discussion_r115327010
--- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/configuration/elastic-site.xml ---
@@ -189,7 +189,12 @@
</property>
<property>
<name>network_host</name>
- <value>"_lo:ipv4_","_eth0:ipv4_"</value>
- <description>Network interface(s) ES will bind to within each node. Confirm names via ifconfig. Should have entries for primary external and loopback interfaces, with :ipv4 annotation and quote marks around each entry: "_lo:ipv4_","_eth0:ipv4_"</description>
+ <value>[ _local_ ]</value>
+ <description>Network interface(s) ES will bind to within each node. Use [ _local_ ] for single-node install; change to [ _local_, _site_ ] (including square brackets) for typical cluster install. See https://www.elastic.co/guide/en/elasticsearch/reference/2.3/modules-network.html for ES documentation.</description>
+ </property>
+ <property>
+ <name>network_publish_host</name>
--- End diff --
@nickwallen , excellent catch, thank you! @JonZeolla , agree. It appears the correct addition is:
```
<value-attributes>
<empty-value-valid>true</empty-value-valid>
</value-attributes>
```
I will add this momentarily.
@nickwallen , to attempt a quick test, one could stop ambari-agent and ambari-server, then edit the file /var/lib/ambari-server/resources/mpacks/metron-ambari.mpack-0.4.0.0/common-services/ELASTICSEARCH/2.3.3/configuration/elastic-site.xml to add those lines to the network_publish_host property. But if the xml file has already been used to create the ambari db, it may be necessary to start over; sorry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #564: Metron-905 Fix square-bracket behavior and defa...
Posted by mattf-horton <gi...@git.apache.org>.
Github user mattf-horton commented on the issue:
https://github.com/apache/incubator-metron/pull/564
Thanks, @nickwallen , will commit shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #564: Metron-905 Fix square-bracket behavior a...
Posted by mattf-horton <gi...@git.apache.org>.
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/564#discussion_r115328348
--- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/configuration/elastic-site.xml ---
@@ -189,7 +189,12 @@
</property>
<property>
<name>network_host</name>
- <value>"_lo:ipv4_","_eth0:ipv4_"</value>
- <description>Network interface(s) ES will bind to within each node. Confirm names via ifconfig. Should have entries for primary external and loopback interfaces, with :ipv4 annotation and quote marks around each entry: "_lo:ipv4_","_eth0:ipv4_"</description>
+ <value>[ _local_ ]</value>
+ <description>Network interface(s) ES will bind to within each node. Use [ _local_ ] for single-node install; change to [ _local_, _site_ ] (including square brackets) for typical cluster install. See https://www.elastic.co/guide/en/elasticsearch/reference/2.3/modules-network.html for ES documentation.</description>
+ </property>
+ <property>
+ <name>network_publish_host</name>
--- End diff --
The addition has been pushed to the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---