You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/08 15:15:46 UTC
[GitHub] [flink] blublinsky opened a new pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
blublinsky opened a new pull request #14591:
URL: https://github.com/apache/flink/pull/14591
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Flink implementation is often a part of the larger application. As a result a synchronized management - clean up of Flink resources, when a main application is deleted is important. In Kubernetes, a common approach for such clean up is usage of the owner's reference (https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)
This PR allows adding owner reference support to Flink Job manager
## Brief change log
- Add configuration for owner reference
- Add Owner manager resource
- Add Owner manager support to KubernetesJobManagerParameters
- Updated Job Manager factory to process owner's reference
- Updated Job Manager factory unit test
## Verifying this change
This change added tests and can be verified as follows:
Running job manager factory unit test
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) yes
- The serializers: (yes / no / don't know) no
- The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know) yes
- The S3 file system connector: (yes / no / don't know)no
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) java doc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12387",
"triggerID" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"triggerType" : "PUSH"
}, {
"hash" : "35947579b06f3b4d67e151e2fc38565813076008",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12488",
"triggerID" : "35947579b06f3b4d67e151e2fc38565813076008",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35947579b06f3b4d67e151e2fc38565813076008 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12488)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #14591:
URL: https://github.com/apache/flink/pull/14591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-769877297
@xintongsong , done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756809971
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-765097625
ping @blublinsky Could you please address the comments before merging?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756809971
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 5789d2337a68e2ffd53419a0e317cf3f272348ec (Fri Jan 08 15:17:18 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5789d2337a68e2ffd53419a0e317cf3f272348ec Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12387",
"triggerID" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"triggerType" : "PUSH"
}, {
"hash" : "35947579b06f3b4d67e151e2fc38565813076008",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12488",
"triggerID" : "35947579b06f3b4d67e151e2fc38565813076008",
"triggerType" : "PUSH"
}, {
"hash" : "402056b79cfdcfeb7c718ca58ec2a96eed1554d0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12668",
"triggerID" : "402056b79cfdcfeb7c718ca58ec2a96eed1554d0",
"triggerType" : "PUSH"
}, {
"hash" : "7100ec24b7b54983f13c1fe5a411aca18ce2e434",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12727",
"triggerID" : "7100ec24b7b54983f13c1fe5a411aca18ce2e434",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 402056b79cfdcfeb7c718ca58ec2a96eed1554d0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12668)
* 7100ec24b7b54983f13c1fe5a411aca18ce2e434 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12727)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on a change in pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #14591:
URL: https://github.com/apache/flink/pull/14591#discussion_r563457159
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -89,6 +89,17 @@
+ TASK_MANAGER_SERVICE_ACCOUNT.key()
+ "' for jobmanager and taskmanager respectively.");
+ public static final ConfigOption<List<Map<String, String>>> JOB_MANAGER_OWNER_REFERENCE =
+ key("kubernetes.jobmanager.owner.reference")
+ .mapType()
+ .asList()
+ .noDefaultValue()
+ .withDescription(
+ "The user-specified owner reference to be set to the JobManager Deployment. "
+ + "The owner reference is used to delete deployment (and the actual cluster) when controlling resource is deleted. "
+ + "The value should be in the form of key:value,where keys define owner reference parameters: apiVersion, "
Review comment:
I think the following two things are not very clear to me after reading the description.
- Why is the owner reference only set for JobManager. Are other resources guaranteed to be cleaned up? We might want to make it more explicit that "delete the actual cluster" means all resources are cleaned up.
- How exactly to use the configuration option. I would suggest to add an example (with multiple owner references).
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -89,6 +89,17 @@
+ TASK_MANAGER_SERVICE_ACCOUNT.key()
+ "' for jobmanager and taskmanager respectively.");
+ public static final ConfigOption<List<Map<String, String>>> JOB_MANAGER_OWNER_REFERENCE =
+ key("kubernetes.jobmanager.owner.reference")
+ .mapType()
+ .asList()
+ .noDefaultValue()
+ .withDescription(
+ "The user-specified owner reference to be set to the JobManager Deployment. "
+ + "The owner reference is used to delete deployment (and the actual cluster) when controlling resource is deleted. "
+ + "The value should be in the form of key:value,where keys define owner reference parameters: apiVersion, "
Review comment:
nit:
```suggestion
+ "The value should be in the form of key:value, where keys define owner reference parameters: apiVersion, "
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-771327097
Thanks @xintongsong for refining the description and merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-767211524
Sorry @xintongsong, are we done now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-768770142
@blublinsky,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12387",
"triggerID" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"triggerType" : "PUSH"
}, {
"hash" : "35947579b06f3b4d67e151e2fc38565813076008",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12488",
"triggerID" : "35947579b06f3b4d67e151e2fc38565813076008",
"triggerType" : "PUSH"
}, {
"hash" : "402056b79cfdcfeb7c718ca58ec2a96eed1554d0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12668",
"triggerID" : "402056b79cfdcfeb7c718ca58ec2a96eed1554d0",
"triggerType" : "PUSH"
}, {
"hash" : "7100ec24b7b54983f13c1fe5a411aca18ce2e434",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12727",
"triggerID" : "7100ec24b7b54983f13c1fe5a411aca18ce2e434",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35947579b06f3b4d67e151e2fc38565813076008 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12488)
* 402056b79cfdcfeb7c718ca58ec2a96eed1554d0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12668)
* 7100ec24b7b54983f13c1fe5a411aca18ce2e434 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12727)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756809971
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7100ec24b7b54983f13c1fe5a411aca18ce2e434 (Fri May 28 08:15:49 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #14591:
URL: https://github.com/apache/flink/pull/14591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on a change in pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on a change in pull request #14591:
URL: https://github.com/apache/flink/pull/14591#discussion_r563796008
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -89,6 +89,17 @@
+ TASK_MANAGER_SERVICE_ACCOUNT.key()
+ "' for jobmanager and taskmanager respectively.");
+ public static final ConfigOption<List<Map<String, String>>> JOB_MANAGER_OWNER_REFERENCE =
+ key("kubernetes.jobmanager.owner.reference")
+ .mapType()
+ .asList()
+ .noDefaultValue()
+ .withDescription(
+ "The user-specified owner reference to be set to the JobManager Deployment. "
+ + "The owner reference is used to delete deployment (and the actual cluster) when controlling resource is deleted. "
+ + "The value should be in the form of key:value,where keys define owner reference parameters: apiVersion, "
Review comment:
1. When deleted, job manager will clean up all all of the resources associated with the cluster, as a result, we only need to delete a job manager to delete a cluster.
2. As for multiple owner references, see here https://medium.com/@bharatnc/kubernetes-garbage-collection-781223f03c17. If an object contains more than one owner reference, it will only be deleted when both of them are deleted. Although it is possible, its rarely used. An example configuration is in KubernetesJobManagerFactoryTest.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5789d2337a68e2ffd53419a0e317cf3f272348ec UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5789d2337a68e2ffd53419a0e317cf3f272348ec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-767211524
Sorry @xintongsong, are we done now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12387",
"triggerID" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"triggerType" : "PUSH"
}, {
"hash" : "35947579b06f3b4d67e151e2fc38565813076008",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12488",
"triggerID" : "35947579b06f3b4d67e151e2fc38565813076008",
"triggerType" : "PUSH"
}, {
"hash" : "402056b79cfdcfeb7c718ca58ec2a96eed1554d0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12668",
"triggerID" : "402056b79cfdcfeb7c718ca58ec2a96eed1554d0",
"triggerType" : "PUSH"
}, {
"hash" : "7100ec24b7b54983f13c1fe5a411aca18ce2e434",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7100ec24b7b54983f13c1fe5a411aca18ce2e434",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35947579b06f3b4d67e151e2fc38565813076008 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12488)
* 402056b79cfdcfeb7c718ca58ec2a96eed1554d0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12668)
* 7100ec24b7b54983f13c1fe5a411aca18ce2e434 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-765454139
Sorry about missing this. Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on a change in pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #14591:
URL: https://github.com/apache/flink/pull/14591#discussion_r564142313
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -89,6 +89,17 @@
+ TASK_MANAGER_SERVICE_ACCOUNT.key()
+ "' for jobmanager and taskmanager respectively.");
+ public static final ConfigOption<List<Map<String, String>>> JOB_MANAGER_OWNER_REFERENCE =
+ key("kubernetes.jobmanager.owner.reference")
+ .mapType()
+ .asList()
+ .noDefaultValue()
+ .withDescription(
+ "The user-specified owner reference to be set to the JobManager Deployment. "
+ + "The owner reference is used to delete deployment (and the actual cluster) when controlling resource is deleted. "
+ + "The value should be in the form of key:value,where keys define owner reference parameters: apiVersion, "
Review comment:
Hi @blublinsky,
You don't need to explain to me, because I'm quite familiar with how these things work for Flink and Kubernetes.
What I meant in the previous comment is that, these things should also be explained in the description of the config option, so that users who may not be as familiar with Flink and Kubernetes as us won't get confused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12387",
"triggerID" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"triggerType" : "PUSH"
}, {
"hash" : "35947579b06f3b4d67e151e2fc38565813076008",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12488",
"triggerID" : "35947579b06f3b4d67e151e2fc38565813076008",
"triggerType" : "PUSH"
}, {
"hash" : "402056b79cfdcfeb7c718ca58ec2a96eed1554d0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12668",
"triggerID" : "402056b79cfdcfeb7c718ca58ec2a96eed1554d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35947579b06f3b4d67e151e2fc38565813076008 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12488)
* 402056b79cfdcfeb7c718ca58ec2a96eed1554d0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12668)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on a change in pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #14591:
URL: https://github.com/apache/flink/pull/14591#discussion_r563457159
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -89,6 +89,17 @@
+ TASK_MANAGER_SERVICE_ACCOUNT.key()
+ "' for jobmanager and taskmanager respectively.");
+ public static final ConfigOption<List<Map<String, String>>> JOB_MANAGER_OWNER_REFERENCE =
+ key("kubernetes.jobmanager.owner.reference")
+ .mapType()
+ .asList()
+ .noDefaultValue()
+ .withDescription(
+ "The user-specified owner reference to be set to the JobManager Deployment. "
+ + "The owner reference is used to delete deployment (and the actual cluster) when controlling resource is deleted. "
+ + "The value should be in the form of key:value,where keys define owner reference parameters: apiVersion, "
Review comment:
I think the following two things are not very clear to me after reading the description.
- Why is the owner reference only set for JobManager. Are other resources guaranteed to be cleaned up? We might want to make it more explicit that "delete the actual cluster" means all resources are cleaned up.
- How exactly to use the configuration option. I would suggest to add an example (with multiple owner references).
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -89,6 +89,17 @@
+ TASK_MANAGER_SERVICE_ACCOUNT.key()
+ "' for jobmanager and taskmanager respectively.");
+ public static final ConfigOption<List<Map<String, String>>> JOB_MANAGER_OWNER_REFERENCE =
+ key("kubernetes.jobmanager.owner.reference")
+ .mapType()
+ .asList()
+ .noDefaultValue()
+ .withDescription(
+ "The user-specified owner reference to be set to the JobManager Deployment. "
+ + "The owner reference is used to delete deployment (and the actual cluster) when controlling resource is deleted. "
+ + "The value should be in the form of key:value,where keys define owner reference parameters: apiVersion, "
Review comment:
nit:
```suggestion
+ "The value should be in the form of key:value, where keys define owner reference parameters: apiVersion, "
```
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -89,6 +89,17 @@
+ TASK_MANAGER_SERVICE_ACCOUNT.key()
+ "' for jobmanager and taskmanager respectively.");
+ public static final ConfigOption<List<Map<String, String>>> JOB_MANAGER_OWNER_REFERENCE =
+ key("kubernetes.jobmanager.owner.reference")
+ .mapType()
+ .asList()
+ .noDefaultValue()
+ .withDescription(
+ "The user-specified owner reference to be set to the JobManager Deployment. "
+ + "The owner reference is used to delete deployment (and the actual cluster) when controlling resource is deleted. "
+ + "The value should be in the form of key:value,where keys define owner reference parameters: apiVersion, "
Review comment:
Hi @blublinsky,
You don't need to explain to me, because I'm quite familiar with how these things work for Flink and Kubernetes.
What I meant in the previous comment is that, these things should also be explained in the description of the config option, so that users who may not be as familiar with Flink and Kubernetes as us won't get confused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756810587
This is replacement for https://github.com/apache/flink/pull/14512
Because the previous fork was removed, had to recreate a PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-762671877
I have run a Flink application on minikube with setting the owner reference of JobManager deployment to a new created service(e.g. my-test-svc). After the service is deleted, all the application K8s related resources, including JobManager deployment, could be deleted by GC. This PR works well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5789d2337a68e2ffd53419a0e317cf3f272348ec Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519)
* 80ea1fb2b7987d406c153526f420e2c73834bea6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12387",
"triggerID" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"triggerType" : "PUSH"
}, {
"hash" : "35947579b06f3b4d67e151e2fc38565813076008",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "35947579b06f3b4d67e151e2fc38565813076008",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 80ea1fb2b7987d406c153526f420e2c73834bea6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12387)
* 35947579b06f3b4d67e151e2fc38565813076008 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on a change in pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on a change in pull request #14591:
URL: https://github.com/apache/flink/pull/14591#discussion_r563796008
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -89,6 +89,17 @@
+ TASK_MANAGER_SERVICE_ACCOUNT.key()
+ "' for jobmanager and taskmanager respectively.");
+ public static final ConfigOption<List<Map<String, String>>> JOB_MANAGER_OWNER_REFERENCE =
+ key("kubernetes.jobmanager.owner.reference")
+ .mapType()
+ .asList()
+ .noDefaultValue()
+ .withDescription(
+ "The user-specified owner reference to be set to the JobManager Deployment. "
+ + "The owner reference is used to delete deployment (and the actual cluster) when controlling resource is deleted. "
+ + "The value should be in the form of key:value,where keys define owner reference parameters: apiVersion, "
Review comment:
1. When deleted, job manager will clean up all all of the resources associated with the cluster, as a result, we only need to delete a job manager to delete a cluster.
2. As for multiple owner references, see here https://medium.com/@bharatnc/kubernetes-garbage-collection-781223f03c17. If an object contains more than one owner reference, it will only be deleted when both of them are deleted. Although it is possible, its rarely used. An example configuration is in KubernetesJobManagerFactoryTest.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756810587
This is replacement for https://github.com/apache/flink/pull/14512
Because the previous fork was removed, had to recreate a PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
xintongsong edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-768770142
Sorry, closed the PR by mistake.
@blublinsky, you have not addressed my comment.
> * Why is the owner reference only set for JobManager. Are other resources guaranteed to be cleaned up? We might want to make it more explicit that "delete the actual cluster" means all resources are cleaned up.
> * How exactly to use the configuration option. I would suggest to add an example (with multiple owner references).
The above should be explained in the configuration option description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12387",
"triggerID" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"triggerType" : "PUSH"
}, {
"hash" : "35947579b06f3b4d67e151e2fc38565813076008",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12488",
"triggerID" : "35947579b06f3b4d67e151e2fc38565813076008",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 80ea1fb2b7987d406c153526f420e2c73834bea6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12387)
* 35947579b06f3b4d67e151e2fc38565813076008 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12488)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-771327097
Thanks @xintongsong for refining the description and merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #14591:
URL: https://github.com/apache/flink/pull/14591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12387",
"triggerID" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 80ea1fb2b7987d406c153526f420e2c73834bea6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12387)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-765097625
ping @blublinsky Could you please address the comments before merging?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12387",
"triggerID" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5789d2337a68e2ffd53419a0e317cf3f272348ec Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519)
* 80ea1fb2b7987d406c153526f420e2c73834bea6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12387)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] blublinsky commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
blublinsky commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-769119537
"_Why is the owner reference only set for JobManager. Are other resources guaranteed to be cleaned up? We might want to make it more explicit that "delete the actual cluster" means all resources are cleaned up."_
Owner reference will ensure deletion of Job manager deployment. Deployment deletion will trigger all instances of Job manager. Job manager deletion will delete all of the Task managers that it controls. As a result deletion of the Job manager deployment leads to deletion of the cluster and setting owner reference on Job manager deployment is sufficient for controlled deletion of the cluster
_How exactly to use the configuration option. I would suggest to add an example (with multiple owner references)._
Example of setting owner reference looks like following:
-Dkubernetes.jobmanager.owner.reference="apiversion":"cloudflow.io/v1beta1",
"blockownerdeletion":"true","controller":"true","kind":"FlinkApplication","name:"testapp","uid":"e3c9aa3f-cc42-4178-814a-64aa15c82373"
Currently multiple owner reference is not supported. It can be added, but there is not real need for this. Usage of multiple owner reference is allowed, but rarely used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-756825239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11817",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11519",
"triggerID" : "5789d2337a68e2ffd53419a0e317cf3f272348ec",
"triggerType" : "PUSH"
}, {
"hash" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12387",
"triggerID" : "80ea1fb2b7987d406c153526f420e2c73834bea6",
"triggerType" : "PUSH"
}, {
"hash" : "35947579b06f3b4d67e151e2fc38565813076008",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12488",
"triggerID" : "35947579b06f3b4d67e151e2fc38565813076008",
"triggerType" : "PUSH"
}, {
"hash" : "402056b79cfdcfeb7c718ca58ec2a96eed1554d0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "402056b79cfdcfeb7c718ca58ec2a96eed1554d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35947579b06f3b4d67e151e2fc38565813076008 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12488)
* 402056b79cfdcfeb7c718ca58ec2a96eed1554d0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on pull request #14591: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes
Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #14591:
URL: https://github.com/apache/flink/pull/14591#issuecomment-769532716
@blublinsky
By **explain in the configuration option description**, I don't mean to explain as comments in this GitHub Pull Request.
In the file `KubernetesConfigOptions.java`, you added a `ConfigOption<xxx> JOB_MANAGER_OWNER_REFERENCE`. This is the **configuration option**. When building this configuration option, there is a `withDescription()`, that sets the **description** for this configuration option. This description will be used for generating documents to help users understand how to use this configuration option.
So what I meant is that we should explain the two questions in this description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org