You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "jpeach (via GitHub)" <gi...@apache.org> on 2023/06/03 02:24:48 UTC
[GitHub] [trafficserver] jpeach opened a new pull request, #9770: Break the circular dependency between iocore and tscore.
jpeach opened a new pull request, #9770:
URL: https://github.com/apache/trafficserver/pull/9770
The re-introduction of the MTHashTable class created a dependency from tscore to iocore, since it uses proxy mutexes, which are tightly coupled to the event system. We can break this circular dependency by moving the class into the QUIC library as an implementation detail, since that already depends on the event system
This fixes #9768.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jpeach commented on pull request #9770: Break the circular dependency between iocore and tscore.
Posted by "jpeach (via GitHub)" <gi...@apache.org>.
jpeach commented on PR #9770:
URL: https://github.com/apache/trafficserver/pull/9770#issuecomment-1575892623
```
Setting up : Copying '/home/jenkins/workspace/Github_Builds/autest/src/tests/gold_tests/pluginTest/polite_hook_wait/.libs/polite_hook_wait.so' to '/tmp/sandbox/polite_hook_wait/ts/plugin' - Passed
Test : Checking that ReturnCode == 0 - Failed
Reason: Returned Value -9 != 0
Time-Out : Process finishes within expected time - Passed
Reason: Returned value: 10.503296613693237 < 600.0
```
Seems like a CI problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jpeach commented on pull request #9770: Break the circular dependency between iocore and tscore.
Posted by "jpeach (via GitHub)" <gi...@apache.org>.
jpeach commented on PR #9770:
URL: https://github.com/apache/trafficserver/pull/9770#issuecomment-1575897129
Wait, the copy isn't the error, I guess it's a return code check from this somewhere?
```
tr = Test.AddTestRun()
tr.Processes.Default.StartBefore(server)
tr.Processes.Default.StartBefore(ts)
tr.Processes.Default.Command = (
'curl --verbose --ipv4 --header "Host:myhost.test" http://localhost:{}/ 2>curl.txt'.format(ts.Variables.port)
)
tr.Processes.Default.ReturnCode = 0
tr = Test.AddTestRun()
tr.Processes.Default.Command = (
'curl --verbose --ipv4 --header "Host:myhost.test" http://localhost:{}/ 2>curl.txt'.format(ts.Variables.port)
)
tr.Processes.Default.ReturnCode = 0
tr = Test.AddTestRun()
tr.Processes.Default.Command = "grep -F HTTP/ curl.txt"
tr.Processes.Default.Streams.stdout = "curl.gold"
tr.Processes.Default.ReturnCode = 0
```
But it's not clear which one fails or why. Exit code 9 from curl is " FTP access denied", so maybe it's the grep that fails? If there's an expected output file, I wonder why the test runs grep manually?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jpeach commented on pull request #9770: Break the circular dependency between iocore and tscore.
Posted by "jpeach (via GitHub)" <gi...@apache.org>.
jpeach commented on PR #9770:
URL: https://github.com/apache/trafficserver/pull/9770#issuecomment-1576033107
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jpeach merged pull request #9770: Break the circular dependency between iocore and tscore.
Posted by "jpeach (via GitHub)" <gi...@apache.org>.
jpeach merged PR #9770:
URL: https://github.com/apache/trafficserver/pull/9770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org