You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/02 00:18:53 UTC
[GitHub] [airflow] mik-laj opened a new pull request #10103: Move Naming Conventions section in CONTRIBUTING.rst
mik-laj opened a new pull request #10103:
URL: https://github.com/apache/airflow/pull/10103
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10103: Move Naming Conventions section in CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10103:
URL: https://github.com/apache/airflow/pull/10103#issuecomment-667608032
The PR title doesn't match the changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10103: Move Naming Conventions section in CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10103:
URL: https://github.com/apache/airflow/pull/10103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10103: Move Naming Conventions section in CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10103:
URL: https://github.com/apache/airflow/pull/10103#issuecomment-667616913
I don't understand why this title is incorrect. Could you say more?
This change doesn't look very good in Github, but you can take a look at the table of contents in this document to evaluate the change.
Before:
<img width="594" alt="Screenshot 2020-08-02 at 04 47 00" src="https://user-images.githubusercontent.com/12058428/89114320-5fb53b00-d47b-11ea-98d2-48ec25dcc016.png">
After:
<img width="567" alt="Screenshot 2020-08-02 at 04 46 47" src="https://user-images.githubusercontent.com/12058428/89114317-5deb7780-d47b-11ea-9649-00ade500cfe3.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org