You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 01:14:28 UTC
[I] [BUG] — Sign "success" tests run with `delay=0` (constructed via `new`, `@Value` unprocessed) → minute-boundary flake [shenyu]
Aias00 opened a new issue, #6816:
URL: https://github.com/apache/shenyu/issues/6816
- severity: Low-Medium; files: `shenyu-plugin-sign/.../service/SignServiceVersionOneTest.java:121,222,242,302,320` (`String.valueOf(System.currentTimeMillis())` expecting `VerifyResult.success()`), `SignServiceVersionTwoTest.java:123`; construction `SignServiceVersionOneTest.java:84` (`new ComposableSignService(new DefaultExtractor(), new DefaultSignProvider())`); field `ComposableSignService.java:80-81` (`@Value("${shenyu.sign.delay:5}") private int delay;` → JVM default `0` when constructed outside Spring)
- description: `ComposableSignService` is constructed via `new` in the tests, so Spring's `AutowiredAnnotationBeanPostProcessor` never processes `@Value` and `delay` stays `0`. The expiry check is `Math.abs(acquireMinutesBetween(start, now)) <= delay` i.e. `<= 0`. A timestamp captured at `MM:59.999` verified at `MM+1:00.001` yields `between=1` → `abs(1) <= 0` is false → unexpected `SIGN_TIME_IS_TIMEOUT`.
- impact: Intermittent failures of all "success-expecting" sign tests on slow/contended CI near minute boundaries.
- suggested_fix: Inject a real `delay` (reflection-set to 5, or construct via Spring test context so `@Value` resolves).
- confidence: High
---
_Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/06-medium-tiers.md`](docs/scan2-2026-08-02/06-medium-tiers.md)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] — Sign "success" tests run with `delay=0` (constructed via `new`, `@Value` unprocessed) → minute-boundary flake [shenyu]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6816:
URL: https://github.com/apache/shenyu/issues/6816#issuecomment-5161324690
👋 Hello @yuluo-yx
A new issue has been opened by @Aias00:
- **Title**: [BUG] — Sign "success" tests run with `delay=0` (constructed via `new`, `@Value` unprocessed) → minute-boundary flake
- **Link**: https://github.com/apache/shenyu/issues/6816
Please review when you have time. Thank you! 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] — Sign "success" tests run with `delay=0` (constructed via `new`, `@Value` unprocessed) → minute-boundary flake [shenyu]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed issue #6816: [BUG] — Sign "success" tests run with `delay=0` (constructed via `new`, `@Value` unprocessed) → minute-boundary flake
URL: https://github.com/apache/shenyu/issues/6816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org