You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2017/08/07 15:55:37 UTC
Review Request 61470: Agent log available with the `/agent/path`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61470/
-----------------------------------------------------------
Review request for mesos and Adam B.
Bugs: MESOS-7864
https://issues.apache.org/jira/browse/MESOS-7864
Repository: mesos
Description
-------
In the effort to get rid of the slave word, this patch aliases the log
path in the agent and makes it available through the `/agent/log`
path.
Diffs
-----
src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b
Diff: https://reviews.apache.org/r/61470/diff/1/
Testing
-------
```sh
make check
```
and
```sh
./bin/mesos-master.sh \
--work_dir=/tmp/alexander/mesos/master \
--log_dir=/tmp/alexander/mesos/master/log &
sudo ./bin/mesos-agent.sh \
--work_dir=/tmp/mesos/agent \
--log_dir=/tmp/mesos/agent/log &
http 127.0.0.1:5051/files/read path==/agent/log offset==0 length==50
# Expected response:
#
# HTTP/1.1 200 OK
# Content-Length: 75
# Content-Type: application/json
# Date: Mon, 07 Aug 2017 15:51:08 GMT
#
# {
# "data": "Log file created at: 2017/08/07 11:50:21\nRunning o",
# "offset": 0
# }
```
Thanks,
Alexander Rojas
Re: Review Request 61470: Agent log available with the `/agent/path`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61470/#review182323
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61470]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 7, 2017, 8:55 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61470/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2017, 8:55 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-7864
> https://issues.apache.org/jira/browse/MESOS-7864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In the effort to get rid of the slave word, this patch aliases the log
> path in the agent and makes it available through the `/agent/log`
> path.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b
>
>
> Diff: https://reviews.apache.org/r/61470/diff/1/
>
>
> Testing
> -------
>
> ```sh
> make check
> ```
>
> and
>
> ```sh
> ./bin/mesos-master.sh \
> --work_dir=/tmp/alexander/mesos/master \
> --log_dir=/tmp/alexander/mesos/master/log &
>
> sudo ./bin/mesos-agent.sh \
> --work_dir=/tmp/mesos/agent \
> --log_dir=/tmp/mesos/agent/log &
>
> http 127.0.0.1:5051/files/read path==/agent/log offset==0 length==50
>
> # Expected response:
> #
> # HTTP/1.1 200 OK
> # Content-Length: 75
> # Content-Type: application/json
> # Date: Mon, 07 Aug 2017 15:51:08 GMT
> #
> # {
> # "data": "Log file created at: 2017/08/07 11:50:21\nRunning o",
> # "offset": 0
> # }
> ```
>
>
> Thanks,
>
> Alexander Rojas
>
>