You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/09/25 08:19:06 UTC
Review Request 38753: CMake: Transition Stout tests to use new
third-party build scripts.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38753/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Transition Stout tests to use new third-party build scripts.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 08325297ceb79b80c305ba4f2164ffd37591a0e8
Diff: https://reviews.apache.org/r/38753/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer
Re: Review Request 38753: CMake: Transition Stout tests to use new
third-party build scripts.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Sept. 25, 2015, 4:58 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake, lines 109-126
> > <https://reviews.apache.org/r/38753/diff/1/?file=1084606#file1084606line109>
> >
> > Just to clarify. You're getting rid of this because of haosdent's VS build script right?
Sorry, are you talking about the comment?
If so, yep, the comment is gone because of the VS build script.
If you're talking about the libraries here, those have been moved to convenience variables like `GLOG_INCLUDE_DIR`.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38753/#review100605
-----------------------------------------------------------
On Sept. 25, 2015, 6:19 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38753/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 6:19 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Transition Stout tests to use new third-party build scripts.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 08325297ceb79b80c305ba4f2164ffd37591a0e8
>
> Diff: https://reviews.apache.org/r/38753/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38753: CMake: Transition Stout tests to use new
third-party build scripts.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38753/#review100605
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake (line 97)
<https://reviews.apache.org/r/38753/#comment157826>
Just to clarify. You're getting rid of this because of haosdent's VS build script right?
3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake (lines 113 - 117)
<https://reviews.apache.org/r/38753/#comment157825>
Looks like you don't need this comment anymore.
- Joseph Wu
On Sept. 24, 2015, 11:19 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38753/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 11:19 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Transition Stout tests to use new third-party build scripts.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 08325297ceb79b80c305ba4f2164ffd37591a0e8
>
> Diff: https://reviews.apache.org/r/38753/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38753: CMake: Transition Stout tests to use new
third-party build scripts.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38753/#review100623
-----------------------------------------------------------
LGTM.
- Artem Harutyunyan
On Sept. 24, 2015, 11:19 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38753/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 11:19 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Transition Stout tests to use new third-party build scripts.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 08325297ceb79b80c305ba4f2164ffd37591a0e8
>
> Diff: https://reviews.apache.org/r/38753/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38753: CMake: Transition Stout tests to use new
third-party build scripts.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38753/#review100745
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Sept. 26, 2015, 6 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38753/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2015, 6 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Transition Stout tests to use new third-party build scripts.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 08325297ceb79b80c305ba4f2164ffd37591a0e8
>
> Diff: https://reviews.apache.org/r/38753/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38753: CMake: Transition Stout tests to use new
third-party build scripts.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38753/
-----------------------------------------------------------
(Updated Sept. 26, 2015, 10:05 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Transition Stout tests to use new third-party build scripts.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 08325297ceb79b80c305ba4f2164ffd37591a0e8
Diff: https://reviews.apache.org/r/38753/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer
Re: Review Request 38753: CMake: Transition Stout tests to use new
third-party build scripts.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38753/
-----------------------------------------------------------
(Updated Sept. 26, 2015, 6 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Transition Stout tests to use new third-party build scripts.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 08325297ceb79b80c305ba4f2164ffd37591a0e8
Diff: https://reviews.apache.org/r/38753/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer