Re: [PR] refactor(parquet): simplify row selection normalization and page scanning [arrow-rs]

["haohuaijin (via GitHub)" <gi...@apache.org>]

haohuaijin commented on code in PR #11687:
URL: https://github.com/apache/arrow-rs/pull/11687#discussion_r4307586971


##########
parquet/src/arrow/arrow_reader/selection/ranges.rs:
##########
@@ -103,11 +103,6 @@ where
                 current_selector = selectors.next();
             }
         } else {
-            if !(selector.skip || current_page_included) {
-                let start = page.offset as u64;
-                let end = start + page.compressed_page_size as u64;
-                ranges.push(start..end);
-            }

Review Comment:
   duplicate with https://github.com/apache/arrow-rs/blob/33d338ddf661b6e85364a9b0bd4d367c3468257d/parquet/src/arrow/arrow_reader/selection/ranges.rs#L83-L88



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org