[jira] [Comment Edited] (FLINK-33443) Make the test "testWriteComplexType" stable

["Martijn Visser (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-33443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782557#comment-17782557 ] 

Martijn Visser edited comment on FLINK-33443 at 11/3/23 12:50 PM:
------------------------------------------------------------------

[~krishaudt14] There's very little/no value in tickets like these. We run CI for every PR, every merged commit, and nightly builds, and test instabilities are logged. If we can't reproduce this in our CI, then let's not spend time on these tickets but focus on the other open tickets. I'm closing this as Can't Reproduce since this requires an additional plugin to be reproduced, which we aren't using in Flink. 


was (Author: martijnvisser):
[~krishaudt14] There's very little/no value in tickets like these. We run CI for every PR, every merged commit, and nightly builds, and test instabilities are logged. If we can't reproduce this in our CI, then let's not spend time on these tickets but focus on the other open tickets. 

> Make the test "testWriteComplexType" stable
> -------------------------------------------
>
>                 Key: FLINK-33443
>                 URL: https://issues.apache.org/jira/browse/FLINK-33443
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / State Backends
>            Reporter: Krishna Anandan Ganesan
>            Priority: Minor
>
> We are proposing to make the following test stable:
> {code:java}
> org.apache.flink.connectors.hive.HiveRunnerITCase.testWriteComplexType{code}
> *STEPS TO REPRODUCE THE ISSUE:*
>  * The following command can be run to execute the test with the [NonDex|https://github.com/TestingResearchIllinois/NonDex] plugin:
> {code:java}
> mvn -pl flink-connectors/flink-connector-hive edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.apache.flink.connectors.hive.HiveRunnerITCase#testWriteComplexType {code}
>  * The following error will be encountered:
> {code:java}
> [ERROR] Failures: 
> [ERROR]   HiveRunnerITCase.testWriteComplexType:166 
> expected: "[1,2,3]	{1:"a",2:"b"}	{"f1":3,"f2":"c"}"
>  but was: "[1,2,3]	{2:"b",1:"a"}	{"f1":3,"f2":"c"}"
> [INFO] 
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0{code}
> *ROOT CAUSE ANALYSIS:*
> The test is currently flaky because of the assumption that the order of elements received in the _result_ variable will be consistent. There are currently two versions of query output that can be stored in _result._
>  # The actual order that is expected where the output of the map attribute is \{1: "a", 2: "b"}.
>  # The other order is the one shown in the error extract above where the ordering of the map attribute from the table is \{2: "b", 1: "a"}.
> *POTENTIAL FIX:*
>  * The fix that I can suggest/have ready to raise a PR for is introducing another assertion on the second variant of the query output.
>  * By asserting on whether the contents in _result_ are in one of the two orders, we can ascertain that the expected attributes with their contents are received as expected should the order in which they are received, not matter.
> Please share your thoughts on this finding and let me know if any other potential fix is possible for this test.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)