You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "jinxxxoid (via GitHub)" <gi...@apache.org> on 2025/05/21 08:09:30 UTC
[PR] IGNITE-25075 Update TX configuration documentation [ignite-3]
jinxxxoid opened a new pull request, #5862:
URL: https://github.com/apache/ignite-3/pull/5862
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25075 Update TX configuration documentation [ignite-3]
Posted by "jinxxxoid (via GitHub)" <gi...@apache.org>.
jinxxxoid commented on code in PR #5862:
URL: https://github.com/apache/ignite-3/pull/5862#discussion_r2099683980
##########
docs/_docs/administrators-guide/config/cluster-config.adoc:
##########
@@ -282,11 +279,9 @@ bin/ignite3 cluster config show > cluster-config.txt
|======
|Property|Default|Description|Changeable|Requires Restart|Acceptable Values
-|abandonedCheckTs|5000|The amount of time after which the transaction is considered abandoned.|Yes|Yes|0 - inf
-|attemptsObtainLock|3|The number of attempts to obtain a lock. After this number of attempts, a lock conflict exception is thrown on the transaction.| Yes | Yes | 0 - inf
-|implicitTransactionTimeout|3000|Timeout for implicit transactions. Used for key-value table APIs invoked with `null` instead of an explicit transaction instance. Must be greater than `rpcTimeout`.| Yes | Yes | 0 - inf
-|rpcTimeout|6000|Timeout for the transaction operation. Used for table API operations.| Yes | Yes | 0 - inf
-|txnResourceTtl|30000|Time to live for transaction resources (transaction states, transaction nodes, open cursors, etc.). Should be higher than the lag to spread the actual transaction information across clusters. Otherwise, some transaction operations might take more time to find out the state from the persistence storage). Must be greater than `rpcTimeout`.| Yes | Yes | 0 - inf
+|readOnlyTimeoutMillis|600000|Timeout for read-only transactions. It defines how long the transaction holds locks or write markers on participating nodes. If no timeout is specified, or it is set to `0`, a default value of 10 minutes is applied. The transaction is guaranteed to remain active until the timeout expires. Once the timeout is reached, the transaction is aborted but may persist briefly beyond the timeout while corresponding resources are cleaned up. Use instead of deprecated `readOnlyTimeout`. | Yes | No | 1 - inf
Review Comment:
agree, changed the descriptions as proposed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25075 Update TX configuration documentation [ignite-3]
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 merged PR #5862:
URL: https://github.com/apache/ignite-3/pull/5862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25075 Update TX configuration documentation [ignite-3]
Posted by "ascherbakoff (via GitHub)" <gi...@apache.org>.
ascherbakoff commented on code in PR #5862:
URL: https://github.com/apache/ignite-3/pull/5862#discussion_r2099660105
##########
docs/_docs/administrators-guide/config/cluster-config.adoc:
##########
@@ -282,11 +279,9 @@ bin/ignite3 cluster config show > cluster-config.txt
|======
|Property|Default|Description|Changeable|Requires Restart|Acceptable Values
-|abandonedCheckTs|5000|The amount of time after which the transaction is considered abandoned.|Yes|Yes|0 - inf
-|attemptsObtainLock|3|The number of attempts to obtain a lock. After this number of attempts, a lock conflict exception is thrown on the transaction.| Yes | Yes | 0 - inf
-|implicitTransactionTimeout|3000|Timeout for implicit transactions. Used for key-value table APIs invoked with `null` instead of an explicit transaction instance. Must be greater than `rpcTimeout`.| Yes | Yes | 0 - inf
-|rpcTimeout|6000|Timeout for the transaction operation. Used for table API operations.| Yes | Yes | 0 - inf
-|txnResourceTtl|30000|Time to live for transaction resources (transaction states, transaction nodes, open cursors, etc.). Should be higher than the lag to spread the actual transaction information across clusters. Otherwise, some transaction operations might take more time to find out the state from the persistence storage). Must be greater than `rpcTimeout`.| Yes | Yes | 0 - inf
+|readOnlyTimeoutMillis|600000|Timeout for read-only transactions. It defines how long the transaction holds locks or write markers on participating nodes. If no timeout is specified, or it is set to `0`, a default value of 10 minutes is applied. The transaction is guaranteed to remain active until the timeout expires. Once the timeout is reached, the transaction is aborted but may persist briefly beyond the timeout while corresponding resources are cleaned up. Use instead of deprecated `readOnlyTimeout`. | Yes | No | 1 - inf
Review Comment:
>It defines how long the transaction holds locks or write markers on participating nodes
I would change it to something more undetailed, like
It defines how long the transaction holds necessary resources on participating nodes
##########
docs/_docs/administrators-guide/config/cluster-config.adoc:
##########
@@ -282,11 +279,9 @@ bin/ignite3 cluster config show > cluster-config.txt
|======
|Property|Default|Description|Changeable|Requires Restart|Acceptable Values
-|abandonedCheckTs|5000|The amount of time after which the transaction is considered abandoned.|Yes|Yes|0 - inf
-|attemptsObtainLock|3|The number of attempts to obtain a lock. After this number of attempts, a lock conflict exception is thrown on the transaction.| Yes | Yes | 0 - inf
-|implicitTransactionTimeout|3000|Timeout for implicit transactions. Used for key-value table APIs invoked with `null` instead of an explicit transaction instance. Must be greater than `rpcTimeout`.| Yes | Yes | 0 - inf
-|rpcTimeout|6000|Timeout for the transaction operation. Used for table API operations.| Yes | Yes | 0 - inf
-|txnResourceTtl|30000|Time to live for transaction resources (transaction states, transaction nodes, open cursors, etc.). Should be higher than the lag to spread the actual transaction information across clusters. Otherwise, some transaction operations might take more time to find out the state from the persistence storage). Must be greater than `rpcTimeout`.| Yes | Yes | 0 - inf
+|readOnlyTimeoutMillis|600000|Timeout for read-only transactions. It defines how long the transaction holds locks or write markers on participating nodes. If no timeout is specified, or it is set to `0`, a default value of 10 minutes is applied. The transaction is guaranteed to remain active until the timeout expires. Once the timeout is reached, the transaction is aborted but may persist briefly beyond the timeout while corresponding resources are cleaned up. Use instead of deprecated `readOnlyTimeout`. | Yes | No | 1 - inf
Review Comment:
>It defines how long the transaction holds locks or write markers on participating nodes
I would change it to something more undetailed, like
It defines how long the transaction holds necessary resources on participating nodes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org