[GitHub] [ozone] rakeshadr commented on a diff in pull request #3348: HDDS-6628. Print OMLockMetrics through obrwf freon command

[GitBox <gi...@apache.org>]

rakeshadr commented on code in PR #3348:
URL: https://github.com/apache/ozone/pull/3348#discussion_r867637968


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OmBucketReadWriteFileOps.java:
##########
@@ -149,6 +155,11 @@ public Void call() throws Exception {
     contentGenerator = new ContentGenerator(fileSizeInBytes, bufferSize);
     timer = getMetrics().timer("file-create");
 
+    mbs = ManagementFactory.getPlatformMBeanServer();
+    bean = new ObjectName(

Review Comment:
   @tanvipenumudy after reading this mbean output, now the metric value stores a combined read/write lock held/waiting time for all the resources. For example, we can't differentiate whether BUCKET_LOCK is consuming long time than the fine grained KEY_PATH_LOCK.
   
   Probably, we need to introduce resource specific metrics to get more granular view about the exact resource(BUCKET, KEY_PATH etc) consumption samples, isn't it?
   
   I've added this comment here to track/remember this point. IMHO, please raise a separate jira sub-task to discuss and provide resource specific metrics values. We can come back to this task once we finish the basic structure.



##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManagerLockMXBean.java:
##########
@@ -0,0 +1,36 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership.  The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.hadoop.ozone.om;
+
+import org.apache.hadoop.hdds.annotation.InterfaceAudience;
+
+/**
+ * This is the JMX management interface for OzoneManagerLock information.
+ */
+@InterfaceAudience.Private
+public interface OzoneManagerLockMXBean {
+
+  String getReadLockWaitingTimeMsStat();

Review Comment:
   Please add javadoc for these functions/APIs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org