You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/07/11 00:14:47 UTC
Re: Review Request 60325: Windows: Replaced `ping` with `Start-Sleep`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60325/#review180075
-----------------------------------------------------------
Ship it!
3rdparty/stout/include/stout/gtest.hpp
Line 229 (original), 229 (patched)
<https://reviews.apache.org/r/60325/#comment255080>
`Start-Sleep` defaults to seconds, but to be absolutely clear, we can add `-Seconds` before `#x`.
- Joseph Wu
On June 21, 2017, 3:09 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60325/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 3:09 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
>
>
> Bugs: MESOS-4467
> https://issues.apache.org/jira/browse/MESOS-4467
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This `SLEEP_COMMAND` macro represents a command that should sleep. On
> POSIX systems, a `sleep` binary is available, but on Windows, `sleep` is
> a `cmd.exe` feature that requires a TTY. Previously, this was replaced
> with `ping` as it approximates sleep, except that it produces noisy
> output. We replace it with the `Start-Sleep` PowerShell command, which
> does not require a TTY, and is always available.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/gtest.hpp a004a378cb467495234d77a0c56fbea6e7bec420
>
>
> Diff: https://reviews.apache.org/r/60325/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>