(hbase) branch branch-3 updated: HBASE-18554 Append#add doesn't check the row of passed cell (#7258)

[zh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a commit to branch branch-3
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-3 by this push:
     new 65a115aa61c HBASE-18554 Append#add doesn't check the row of passed cell (#7258)
65a115aa61c is described below

commit 65a115aa61ccd1ec09f53ce2ee70c6dea6cd2262
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Wed Sep 3 18:20:19 2025 +0800

    HBASE-18554 Append#add doesn't check the row of passed cell (#7258)
    
    Signed-off-by: Nihal Jain <ni...@apache.org>
    (cherry picked from commit 0c1228724092dcded5b73ec6e28f718c992a8e11)
---
 .../src/main/java/org/apache/hadoop/hbase/client/Append.java     | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
index 81cf86ed207..9f414a6e2db 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
@@ -18,6 +18,7 @@
 package org.apache.hadoop.hbase.client;
 
 import java.io.IOException;
+import java.io.UncheckedIOException;
 import java.util.List;
 import java.util.Map;
 import java.util.NavigableMap;
@@ -154,14 +155,18 @@ public class Append extends Mutation {
   /**
    * Add column and value to this Append operation.
    * @return This instance
+   * @deprecated Since 3.0.0, and the method signature will be changed in 4.0.0, where we will throw
+   *             IOException out when the row of the given cell does not match.
    */
+  @Deprecated
   @Override
   public Append add(final Cell cell) {
     try {
       super.add(cell);
     } catch (IOException e) {
-      // we eat the exception of wrong row for BC..
-      LOG.error(e.toString(), e);
+      // we can not simply change the method signature for a IA.Public method, so here we convert it
+      // to an unchecked exception
+      throw new UncheckedIOException(e);
     }
     return this;
   }