[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4235: ARTEMIS-4020: use SLF4J logging API, with Log4J as impl for broker

[GitBox <gi...@apache.org>]

gemmellr commented on code in PR #4235:
URL: https://github.com/apache/activemq-artemis/pull/4235#discussion_r982576669


##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/AutoCreateUtil.java:
##########
@@ -47,7 +50,7 @@ public static  void autoCreateQueue(ClientSession session, SimpleString destAddr
                      .setAddress(destAddress);
                setRequiredQueueConfigurationIfNotSet(queueConfiguration,response, RoutingType.ANYCAST, selectorString, true);
                session.createQueue(queueConfiguration);
-               ActiveMQClientLogger.LOGGER.debug("The queue " + destAddress + " was created automatically");
+               logger.debug("The queue " + destAddress + " was created automatically");

Review Comment:
   Yeah there are plenty of concats left..I converted a bunch when I happened to be changing a specific line already, or just had for others in a class, but definitely we didnt try to remove them all (Clebert even likes them :P). A whole other massive PR could be done around that and e.g removing various gating still existing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org