You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Omega359 (via GitHub)" <gi...@apache.org> on 2024/04/12 20:45:55 UTC

Re: [PR] Disable `crypto_expressions` feature properly for --no-default-features [arrow-datafusion]

Omega359 commented on code in PR #10059:
URL: https://github.com/apache/arrow-datafusion/pull/10059#discussion_r1563183115


##########
datafusion/functions/Cargo.toml:
##########


Review Comment:
   I just went through the Cargo.toml files and discovered that the defaults are kinda b0rken in multiple places. I think another ticket would be in order - or else this ticket should be just titled 'fix the expression feature defaults to allow for proper disabling of features' and all the fixes done here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org