You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/07 20:51:53 UTC
[GitHub] [spark] rdblue commented on a change in pull request #28993: [SPARK-32168][SQL] Fix hidden partitioning correctness bug in SQL overwrite
rdblue commented on a change in pull request #28993:
URL: https://github.com/apache/spark/pull/28993#discussion_r451135737
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/InsertIntoTests.scala
##########
@@ -446,8 +446,7 @@ trait InsertIntoSQLOnlyTests
}
}
- test("InsertInto: overwrite - multiple static partitions - dynamic mode") {
- // Since all partitions are provided statically, this should be supported by everyone
+ dynamicOverwriteTest("InsertInto: overwrite - multiple static partitions - dynamic mode") {
withSQLConf(PARTITION_OVERWRITE_MODE.key -> PartitionOverwriteMode.DYNAMIC.toString) {
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org